Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ build workflow #1065

Merged
merged 83 commits into from
Sep 20, 2024
Merged

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Sep 18, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1446

📔 Objective

Fix the C++ build workflow. Relies on changes from #1002, which will need to be merged first.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Logo
Checkmarx One – Scan Summary & Detailsdf8b6f1f-4476-4e33-894b-1a61db3051b4

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.12%. Comparing base (dd555ce) to head (3d8dd9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         197      197           
  Lines       13532    13532           
=======================================
  Hits         7865     7865           
  Misses       5667     5667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review September 19, 2024 17:15
@tangowithfoxtrot tangowithfoxtrot requested a review from a team as a code owner September 19, 2024 17:15
@tangowithfoxtrot tangowithfoxtrot changed the title Test cpp vcpkg with rustls workaround Fix C++ build workflow Sep 19, 2024
@tangowithfoxtrot tangowithfoxtrot merged commit eeda462 into main Sep 20, 2024
83 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the test-cpp-vcpkg-with-gnu-workaround branch September 20, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants