New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds infinite maps docs #1708

Merged
merged 3 commits into from Aug 29, 2017

Conversation

Projects
None yet
2 participants
@ketanhwr
Contributor

ketanhwr commented Aug 28, 2017

No description provided.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Aug 28, 2017

Owner

Please wrap the lines, say to 78 characters.

The documentation for <chunk> is too short. It should mention "Can contain: tile", like other elements are documenting their possible child elements. Also, the element should be mentioned at <data>, at least as part of the "Can contain" list of elements.

Somewhere, probably as part of the <chunk> documentation, it should be mentioned that the contents is the same as for the <data> element, except that it only stores the data for the area specified with the attributes and that no <chunk> element can be nested in a <chunk>.

Owner

bjorn commented Aug 28, 2017

Please wrap the lines, say to 78 characters.

The documentation for <chunk> is too short. It should mention "Can contain: tile", like other elements are documenting their possible child elements. Also, the element should be mentioned at <data>, at least as part of the "Can contain" list of elements.

Somewhere, probably as part of the <chunk> documentation, it should be mentioned that the contents is the same as for the <data> element, except that it only stores the data for the area specified with the attributes and that no <chunk> element can be nested in a <chunk>.

@bjorn bjorn added the documentation label Aug 28, 2017

ketanhwr and others added some commits Aug 29, 2017

@bjorn bjorn merged commit edebb3b into bjorn:master Aug 29, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment