support Metal renderer to auto generate mipmap for render target #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @attilaz |
dmarcinkovic
pushed a commit
to DeepARSDK/bgfx
that referenced
this pull request
Nov 20, 2023
Apply commit from PR bkaradzic#2784
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
…radzic#2784) * support render target auto generate mipmap * move autoGenMipmap check to s_textureFormat table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need metal renderer to auto generate mipmap, other renderer have been supported about this.
And I found this issue have discuss about this:
#798
So I follow this discuss and make it work.
Here is the document I referenced:
https://developer.apple.com/documentation/metal/mtlblitcommandencoder/1400748-generatemipmapsfortexture
https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf
Something should note about which format can generate mipmap.
As the document say that, texture format should:
And the format support color-renderable and color-filterable can be found in Metal-Feature-Set-Tables.pdf
But RBGA32F/RGBA32U/RGBA32I format is not list as filterable. I try in my device(Macbook pro M1), it work.