fix metal and vulkan renderer set image bug #3083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have pulled a PR:
#3063
It try to fix set image without sampler state bug in vulkan.
After compare with D3D11 and D3D12, it should check the bind.m_access type, if it is Access::Read, the sampler state must be set.(I just follow D3D11 and D3D12 renderer, and try to make vulkan and metal renderer keep the same logic). The sampler state is needed both compute and render pipelines.
https://github.com/bkaradzic/bgfx/blob/master/src/renderer_d3d11.cpp#L5813
https://github.com/bkaradzic/bgfx/blob/master/src/renderer_d3d11.cpp#L6144
https://github.com/bkaradzic/bgfx/blob/master/src/renderer_d3d12.cpp#L6613
https://github.com/bkaradzic/bgfx/blob/master/src/renderer_d3d12.cpp#L6925