Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Made QTMarlin compatible QT5. Modernize code to be compatible with … #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SvenW78
Copy link

@SvenW78 SvenW78 commented Nov 20, 2016

…newer compilers.

-Remove dependency from external SerialPort lib (use QT5 included lib)
-Tested with QWT 6.1.3, MacOs, Linux, Windows
-Cleanup header include and pro file dependency, which mades the compile time 10 times faster
-Cleanup all warnings
-Functionality is still the same now, but we have a modern code base

…ewer compilers.

-Remove dependency from external SerialPort lib (use QT5 includes lib)
-Tested with QWT 6.1.3, MacOs, Linux, Windows
-Cleanup header include and pro file dependency, which mades the compile time 10 times faster
-Cleanup all warnings
-Functionality is still the same now, but we have a modern code base
Copy link

@eduard-sukharev eduard-sukharev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great job. Although, i think that there might be some easier way of installing QWT than the one described in readme, the provided solution is good enough.
I would merge it if i were the original author. Meanwhile, i would use your forked version ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants