Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Changed logic to include the generated locales if no locale exists. #449

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

Blackbaud-BobbyEarl
Copy link

Quick attempt at solving blackbaud/skyux2#1773

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #449 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   99.32%   99.32%   +<.01%     
==========================================
  Files          73       73              
  Lines        1922     1925       +3     
  Branches      304      305       +1     
==========================================
+ Hits         1909     1912       +3     
  Misses         13       13
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 95.6% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/sky-pages-assets-generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ead8c7...408c180. Read the comment docs.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ixed bug with letting SPA local files override lib files.
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit d7e95b6 into master Aug 13, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the include-default-locale branch August 13, 2018 15:08
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants