Last minute fixes, examples, and updated documentation. #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting these during POST broke CookieAuth. Further testing shows that bd.session.post(..., json=) will set the content-type header automatically to "application/json" so the defaults are not needed during POST (nor DELETE).
|
I don't really need a code review for this (mostly minor fixes plus sample files). With these changes I am feeling 98% confident that we can enter the code-freeze stage. I've updated the documentation and wouldn't mind having you take a look at that. See my fork to see the shortened README.md and you can look at the wiki. |
OffBy0x01
approved these changes
Apr 16, 2021
mkumykov
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Also see the updated wiki