Containers #74
Merged
Containers #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnyder2007
suggested changes
Dec 9, 2019
blackduck/HubRestApi.py
Outdated
| @@ -845,7 +845,7 @@ def get_or_create_project_version(self, project_name, version_name, parameters = | |||
| if project: | |||
| version = self.get_version_by_name(project, version_name) | |||
| if not version: | |||
| self.create_project_version(project, version_name, parameters) | |||
| self.create_project_version(project, version_name, parameters=parameters) | |||
| version = self.get_version_by_name(project, version_name) | |||
| else: | |||
| self.create_project(project_name, version_name, parameters) | |||
There was a problem hiding this comment.
should this also be changed? parameters=parameters?
There was a problem hiding this comment.
Yes, that is correct
get_or_create_project_version(
gsnyder2007
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SAP, layer matching for base container image layers modified to use SHA256 ids.
Project structure removal is modified to allow multiple versions of a container image to co-exist nicely