HierarchicalField, JsonExtractor, and FilterBuilder #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psantos1113
reviewed
Oct 26, 2018
| /** | ||
| * @return an unmodifiable list of fields representing the path to the parent element of the inner most field defined by this class | ||
| */ | ||
| public List<String> getPathToField() { |
There was a problem hiding this comment.
change the method getPathToField to getParentPath
| /** | ||
| * @return an unmodifiable list of fields representing the path to a field nested within an object | ||
| */ | ||
| public List<String> getFullPathToField() { |
There was a problem hiding this comment.
Change this to getFullPath . The ToField is implied given that we are a HierarchicalField. It being a JSON field seems to be implied.
|
Changing the impl, but I'll leave the branch alone if you still want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.