[pull] master from web-platform-tests:master #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Correctly handle keyword sizes when computing the min-content or max-content contribution of a box. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Text in the sideways-lr writing mode should grow upward from "current text position". This CL supports `x` `y` `dx` `dy` and `text-anchor` for the sideways-lr writing mode. `textLength` and `<textPath>` will be supported later. Bug: 40501131 Change-Id: If67215f59b9b623a92a06cbc56457a323362255e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963882 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374467}
…>` elements when `white-space` is `pre`, `pre-wrap` or `pre-line Currently, the expectations include `<br>` element cases even if `white-space` value is `pre`, `pre-wrap` or `pre-line`. However, in these cases, only `\n` should be allowed because `<br>` elements are not converted to `\n` if web apps gets the editing host value with `.textContent`. Differential Revision: https://phabricator.services.mozilla.com/D226441 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1926194 gecko-commit: 69bbad8c218d32f119ad2a87445ef1f067a7426c gecko-reviewers: m_kato
Differential Revision: https://phabricator.services.mozilla.com/D226293 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1923831 gecko-commit: 7fd5f1828e651b138fd3cec1d642ecd3ed1649ad gecko-reviewers: webdriver-reviewers, whimboo
… be the size of the screen on Wayland. Differential Revision: https://phabricator.services.mozilla.com/D226294 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1923831 gecko-commit: 4251a2ed50a87d1c23653256142ab6353359b783 gecko-reviewers: webdriver-reviewers, whimboo
`in_negation` was `true` in cases where it should be `false`, like `:not(:not(...))`. Differential Revision: https://phabricator.services.mozilla.com/D226582 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1926164 gecko-commit: ecd7dce029ce3806cdfe35af7e38b2b03a4dd313 gecko-reviewers: dshin, jwatt
Just use LayoutInputNode's IsFloatingOrOutOfFlowPositioned(), rather than that of the node's LayoutObject / LayoutBox. The LayoutBox of an InlineNode is the container, and the container's out-of-flowness doesn't matter for the lines inside. Lines are always considered to be in-flow. Bug: 40254880 Change-Id: Id0f7965963ad17098e7bdbb5ba777c1d885f1829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961784 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374568}
Replace what crrev.com/c/5905670 did. The detection code is now in BlockLayoutAlgorithm(). Border / padding at the container that establishes box trimming shouldn't be considered to be intervening. Only check border/padding on descendants. Bug: 40254880 Change-Id: I45b7c28f5dd37df20eb90c377759642fd3b76ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960337 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374580}
…48740) Cross-origin isolation is more appropriate for render times than TAO, as it's a document-level protection rather than resource-level. Using FloorToMultiple instead of TimeClamper, as randomization is both unnecessary here, and would create incompatible results between different entries. Bug: 373263977 Change-Id: I7715d26c7732b69078aa5bb2ce8614100932e971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5930666 Reviewed-by: Michal Mocny <mmocny@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374558} Co-authored-by: Noam Rosenthal <nrosenthal@chromium.org>
…#48809) This behavior is similar to that of `content_shell` [0] and is needed to avoid bogus failures. Fixes https://crbug.com/374852560. Tested locally in `chromium/src` with: ```sh git cl patch https://crrev.com/c/5951685/4 run_chrome_wpt_tests external/wpt/nav-tracking-mitigations/leftover-window.sub.https.html \ -v --enable-leak-detection ``` [0]: https://source.chromium.org/chromium/chromium/src/+/main:content/web_test/browser/web_test_control_host.cc;l=2068-2072;drc=332e097811931e865be49054b6681e2c9fb5f4cf;bpv=0;bpt=0
Following the discussion on the WhatWG issue for Enhanced TextMetrics, it was agreed that TextClusters should be rendered with values defined in CanvasTexDrawingStyles as they were when ctx.measureText() was called, with the exception of text align and baseline if they are passed as options to TextMetrics::getTextClusters() (see: https://html.spec.whatwg.org/#canvastextdrawingstyles). This means that even if any of these values changes between the moment that ctx.measureText() was called, and the time they are rendered with ctx.fillTextCluster(), the styles will be preserved as they were when the text was measured. A previous test already checks if that is the case for the font. This CL adds a test that checks this for letterSpacing, wordSpacing, fontKerning, and fontVariantCaps. Some drawing styles require more specific set ups (fontStretch and textRendering), and will have tests added in future CLs. Bug: 341213359 Change-Id: I4b123633b3e4951385145596388cf5b192221465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5948244 Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org> Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374809}
…nce (#48844) According to the bug, ChromeDriver now fully supports the standard "set timeouts" endpoint, so there's no need to fall back to the nonstandard endpoint.
According to discussion[1] in webappsec WG and WHATWG, we should set the default of `focus-without-user-activation` permissions policy to `EnableForSelf`. [1]: w3c/webappsec-permissions-policy#273 (comment) Bug: 371112534 Change-Id: I7deb757d0074e1262d07f768e58ea53a99d5faa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950528 Reviewed-by: Sanket Joshi <sajos@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374868}
Differential Revision: https://phabricator.services.mozilla.com/D226815 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1907808 gecko-commit: 1ec7ee1dc81bde2f10e3386190f63cbd00042c22 gecko-reviewers: emilio
A selection preservation test for the `moveBefore()` API was added in https://crrev.com/c/5725934 which passes falsely / incorrectly. Selection preservation has not been fully implemented in Chromium, but this test passes for two reasons: 1. Inside the old parent from which the moved element is moved, there is no text except for the moved text. This appears to have a weird side-effect — if we `moveBefore()` from a parent that is otherwise empty, the selection returned by the `getSelection()` API appears to have the `anchorNode` still set to the new freshly-moved node. On the contrary, if you move text from a parent that has plenty of other preceding text, the selection returned from `getSelection()` *after* the move sticks to the preceding text, and indicates that the selection API does not preserve properly across moves. 2. Before the `moveBefore()` API is called, `getSelection().anchorNode` is called. This *ALSO* has a weird side-effect of computing the `DocumentCachedRange()`, and since we have implemented the behavior to *NOT* update Ranges during an atomic move (in https://crrev.com/c/5725934), the cached range from before `moveBefore()` persists and deceptively indicates that selection has been preserved, when it hasn't been. Specifically, the cache range was indeed "preserved" by virtue of not being modified during the move, but in reality the *visual* (highlighted) selection was not preserved, and becomes out-of-sync with the cached Range selection returned by the selection API. By *NOT* calling `getSelection()` before the move, we ensure that we do not generate a cached selection Range, and by *only* calling `getSelection()` *after* the move, we force the Selection API to generate a cached selection Range based off of the actual visual selection, which gives us a truer picture of what the visual selection (the stuff that the user sees) *actually* is. The test that this CL modifies accidentally relied on these two quirks above, which made the test pass even though true selection preservation was not implemented. This CL updates the test to not lean on these quirks, so that it fails appropriately. A subsequent CL will implement *visual* selection preservation properly, ensuring that the Selection API's cached selection Range can never get out of sync with the visual selection. That CL will add more tests and mark this one as passing. R=nrosenthal@chromium.org Bug: 40150299 Change-Id: Ifba24444f0c067643df650c69fb631fd94273d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966878 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374916}
After bef892c, Safari had a number of tests change behaviour: https://wpt.fyi/results/?diff&filter=ADC&run_id=5195649314455552&run_id=5132128627195904 Ultimately, this is because we practically checked windows closed before, because the "Hope the first one here is the test window" comment turned out to almost always be untrue in Safari. This actually leaves us somewhere better than that, as it makes the check explicit, and as long as close_after_done is True (which it typically is), it makes the test that left us in the broken state come back as ERROR, rather than the following test.
…cked files (#48797) * move new role/description/colindextext/rowindextext to tentative; add back in 2025 Closes web-platform-tests/interop-accessibility#151
Differential Revision: https://phabricator.services.mozilla.com/D226986 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1497430 gecko-commit: cf836d486e029a779847a21d3130581cce46862b gecko-reviewers: webidl, asuth
Differential Revision: https://phabricator.services.mozilla.com/D225482 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1924323 gecko-commit: b8171301bcf35ae5a90fc910d69885673d507e17 gecko-reviewers: dom-storage-reviewers, asuth
Update the behavior of dynamic-range-limit to reflect the spec changes in the issue w3c/csswg-drafts#10271 and the PR w3c/csswg-drafts#11086. Add assorted unit tests. Add WPT tests for computed value, parsing, inheritance, and interpolation. Bug: 40277822 Change-Id: I0fcd81538546a7428080dc691ba91ccc7803f59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501416 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1375223}
This makes calls to ParentNode.append() and similar methods that pass the same node multiple times ignore all but the last occurrence of the repeated node. This matches the behavior when a temporary DocumentFragment was used. Fixed: 375493447 Change-Id: I36035e09bfc2a78f53f2ef63a1506b08d28bb9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5967474 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1375292}
The current failures are all due to test driver APIs used on unsupported test types. Move those tests to wpt_internal and run the rest with headless shell. Bug: 40927590 Change-Id: I45776729912f60fb24bccad9873be9cec92b8f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972758 Commit-Queue: Jonathan Lee <jonathanjlee@google.com> Auto-Submit: Weizhong Xia <weizhong@google.com> Reviewed-by: Jonathan Lee <jonathanjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1375296}
Bug: 40150299 Change-Id: I27f9a089fab60073e1bc66370f339dffbe9917ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938233 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1375312}
The runs on the CI (TaskCluster) of WebKitGTK have been not working since a while [1] because the nightly bundles that we were shipping for download [2] for testing on the WPT CI stopped working due to binary compatibility issues. So we decided [3] that instead of shipping a bundle for a specific distro we would ship an universal bundle that can work on any distro. This allows us to ship a bundle with all the preview features enabled and the last versions of all the libraries, matching the same configurations that are tested on the release WebKitGTK bots at build.webkit.org This commit changes the taskcluster init tasks, as also the installation of the webkitgtk_minibrowser bundles to use this new universal bundle. This also allows now developers to test with webkitgtk_minibrowser nightlies independent of the distro they have. They simply need to pass the flags "--install-browser --channel=nightly" to "wpt run" [1] Fixes: #47823 [2] https://webkitgtk.org/built-products/x86_64/release/nightly [3] https://bugs.webkit.org/show_bug.cgi?id=280523
This was missed in the existing set of popover tests. Bug: 40218886 Change-Id: Id265a70e4f933aa484768509896a9bb156db4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5973789 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1375302}
Defined in: w3c/csswg-drafts#10986 Bug: 369319576 Change-Id: I4161a9a0111ff2247ab6d9009c5bdec96ac1c855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5967877 Commit-Queue: Traian Captan <tcaptan@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1375343}
…subtests (#48862) One for the events emitting after lostpointercapture. The other one for no events being emitted.
This avoids `__str__` having a trailing new line (as this makes it odd to include in a typically single-line error message), and remove excess whitespace (all ASCII from the message, new lines from the stacktrace). Additionally, make the message match the stacktrace: set it to None unless we have a non-empty string. Both are implementation defined, and in both cases they are sometimes empty. This makes the `if self.message is not None` work as intended within `__str__`.
Spec PR: w3c/csswg-drafts#11172 Bug: 40287550 Change-Id: Ibf930266cc78738c69e7629473a60cb9c5d67a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6003155 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381100}
I traced these back to: hickson Early draft of the CSS2.1 Test Suite https://github.com/web-platform-tests/wpt/blob/fa9f560a5dd74425196782657c3c901777313a53 The nested support swatch images were initially used by support/css1test64a.css and support/css1test64b.css [1] to test relative uris, as these referenced either css1tests/support/support/swatch-red.png or css1tests/support/swatch-red.png. We no longer have any references to swatch-green.png or swatch-red.png from within support/, so these can just be removed. [1] https://github.com/web-platform-tests/wpt/blob/fa9f560a5dd74425196782657c3c901777313a53/cvs-import/CSS2.1-test-suite/raw-tests/css1tests/support/css1test64b.css Change-Id: I6314a01f2f9f965754d442f5e87c2aedc0187d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000968 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1381105}
This CL should have no user-visible behavior changes. Change-Id: I3efe07c47f01f3f0350647226393762ad238f241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6008884 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381096}
The load event waits for resources such as images and stylesheets to load, but does not guarantee that child iframes have loaded. This test was flaking on debug and MSAN builds which are inherently slower and susceptible to race conditions. This patch addresses the race condition by deferring loading the iframe until we can trap the signal that loading is complete, and is a speculative fix for the flake. Several other tests in this directory also use iframes and may have the same race condition. Deferring adding a common resource tool for a frame load promise pending further investigation of these other tests. Bug: 352327319 Change-Id: I7a815916a62b00ac78ed1fbdc884a61c9c8de152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000632 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381194}
This CL enables moveBefore() inside connected ShadowRoot DocumentFragments, as the general only-Element-node target parent pre-condition was too strict, and disabled this case, despite it being a pretty valid one. This was discussed in whatwg/dom#1307 (comment). R=nrosenthal@chromium.org Bug: 40150299 Change-Id: Ie9c6e31400b75b2b5d10d095c059012056a440da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012161 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381208}
Pressing up or down on the first or last option of a customizable select should not let the document scroll. This was happening because the default event handler of the option was not handling the default if there was no option to focus in this keyboard event handler, but by setting the default as handled anyway this bug goes away. This was identified here: openui/open-ui#1087 (comment) Change-Id: I56ab094f468df1ef4847011763e20ea7e759d3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006515 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Traian Captan <tcaptan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381284}
Also, change the usage of `createVideoFrame()` to `createFlowingVideoStream() to resolve an issue: For video encoding on macOS, when the second HEVC compression session is created, and when GPU is x64 arch, `MaxKeyFrameIntervalDuration` of VT may suddenly became unsupported, this changes the encoder behaviour, resulting `CompressionCallback()` won't always be triggered immediately when the first frames came, So we need the video stream to constantly generate new frames to make sure the test passes. Bug: 40276507 Change-Id: If9a065a9c15b3cece6a2fa04c0fe5c59bbd3d1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6008857 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sida Zhu <zhusida@bytedance.com> Cr-Commit-Position: refs/heads/main@{#1381309}
Added tests for size and scroll-state queries. Style queries should already be covered. Bug: 378421865 Change-Id: Iee14dd12077a5c9cb40fbc248b61cbbf127dfc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6011249 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381332}
Fixed: 372994343 Change-Id: I1e469bcfd8f23d38e1641f7e944c46743b934c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006218 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381342}
The recent [1] CL added a CHECK that when showing a dialog, there is no existing close watcher, but it fails in the case that the open attribute is manually removed. This CL fixes that case. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5990171 Fixed: 378159143 Bug: 376516550 Change-Id: I91e955d15bd109d176b7f2cf2b622431ca884909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013313 Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381372}
Fixed: 372736019 Change-Id: Ic8c36b1a5b98ebbbc4eac55db9b7105fdd03a910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006198 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381378}
We add a trivial /.well-known/shared-storage/trusted-origins handler so that we can make a PR update (#49112) to third_party/wpt_tools/wpt/tools/serve/serve.py to handle this file. Later, when we add tests, we will also add nontrivial logic to trusted_origins.py. Bug: 376278213 Change-Id: Ied0ba6690c67dcff3ebbdb1d81794889c7b6f37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6011586 Reviewed-by: Yao Xiao <yaoxia@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381524}
This is a reland of commit 1ff996297a57783a387e0031bc40d3343db3cfcb Changes from the original CL: TrailingCollapsibleSpace should store pairs of a Vector and an index instead of InlineItemResult pointers. We append InlineItemResult instances to an InlineItemResults vector after calling ComputeTrailingCollapsibleSpace(), which makes a TrailingCollapsibleSpace. So an InlineItemResult address can be changed. Original change's description: > layout: Fix trailing collapsible space handling with <ruby> > > * Trailing collapsible space should not be handled in ruby-base lines > because such lines are contained by another line. > This CL introduces `LineBreaker:: > disable_trailing_whitespace_collapsing_`. > > * ComputeTrailingCollapsibleSpace() should iterate inside ruby columns > recursively. > > * RemoveTrailingCollapsibleSpace() and TrailingCollapsibleSpaceWidth() > should compute ruby column widths correctly. > > * ruby-intra-level-whitespace-001.html passed accidentally. It requires > <rb> and table-like pairing. > > Bug: 376097115 > Change-Id: I55e4559012ec08c9b423ad8a518890c02862d857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996911 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Kent Tamura <tkent@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1379515} Bug: 376097115, 377943756, 378102636, Change-Id: Ida30674a41c8f4d03e5b388c469345e7f36acdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6010169 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381580}
…as a custom error According to specifications [1]: - The `setCustomValidity(error)` method steps are: - 1. Set error to the result of normalizing newlines given error. - 2. Set the custom validity error message to error. - `element.validity.customError`: - Returns true if the element has a custom error; false otherwise. When the object element uses `setCustomValidity` to set a custom error, the element's `validity.customError` should be set to true. `HTMLObjectElement` does not need to override related functions. [1]: https://html.spec.whatwg.org/multipage/#dom-validitystate-customerror Bug: 40781343 Change-Id: I99500d2ffed863ba9ed7c760c36ca6d0c08c6978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999040 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Peng Zhou <zhoupeng.1996@bytedance.com> Cr-Commit-Position: refs/heads/main@{#1381597}
Differential Revision: https://phabricator.services.mozilla.com/D228577 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1926732 gecko-commit: 903b79dc3e7f2a1bdd4d3931b2d6b73d2304a712 gecko-reviewers: layout-reviewers, emilio
With line-clamp, all content after the clamp point in the layout tree should be hidden for paint; however, atomic inlines and inline images weren't. This patch fixes this. Bug: 40336192 Change-Id: I2dde3b5d4959f4019c12507b14776221f98d1c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6010756 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1381632}
This CL should have no user-visible behavior changes. Change-Id: I1a4862e4762de9a3d13e99ff355a40445b85d887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013799 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381633}
This CL is to deprecate `compute()` and use MLTensor. Bug: 333791040 Change-Id: Iecd600245f291d26fd85da9ab6a0d1f05e25f6e9 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac15.arm64-blink-rel,linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5556220 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Auto-Submit: Feng Dai <feng.dai@intel.com> Commit-Queue: Feng Dai <feng.dai@intel.com> Cr-Commit-Position: refs/heads/main@{#1381625}
Relanding with a build fix(spurious -blink include) Instead of capturing the border offset, we capture the following layout sizes to determine sizing, in addition to the border box: - padding box - content box - The box-sizing property - In layered capture mode, we use the content box size as the reference box for positioning the snapshot, so that padding take effect. - The ::view-transition-image-pair pseudo-element now has position:relative so that it gets affected by padding. It has the content box size. - The width/height of the group is determined by the box-sizing property, and it receives the computed padding. Bug: 375395117 Change-Id: Ide0c001ea17582bb854a2fe678965504e0d4c0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6011700 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381667}
Differential Revision: https://phabricator.services.mozilla.com/D227696 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1928702 gecko-commit: bda570180adfcc20891d5cfb47406756fe8903ad gecko-reviewers: asuth
It's a leftover from when buttons were implemented as flex containers. We can remove it now. The new behavior matches to Firefox. Bug: 40681980 Change-Id: Iee119a3e73a649b1eea2e680983836a064162818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013405 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381805}
…ze.html Bug: 343263984 Change-Id: I0dc8e75c063e7b6d062acdb0726bb43f11a1b1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013247 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381802}
We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed #49112.)
This CL resolves issues with the forced colors mode tests in the headless shell test environment. The errors occurred because the link color in some reference files was not explicitly set to "VisitedText", as is currently done in forced colors mode. Consequently, many actual results did not match the expected results solely due to the link color discrepancy. For more details, refer to this test bucket[1]. Most errors in the Windows scenario should be resolved with this change, except for `forced-colors-mode-03.html`, which requires further restructuring based on recent findings about the test's structure. This will be addressed in a subsequent CL. Failures on MacOS and Linux platforms will also be handled in a subsequent CL. [1]: https://chromium-layout-test-archives.storage.googleapis.com/results.html?json=chromium/ci/win10-wpt-chromium-rel/3919/headless_shell_wpt_tests_include_all%20%28experimental%29/full_results_jsonp.js Bug: 368396826 Change-Id: Ifc925637e0f1438a5241017de7a2f3023380997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012900 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1382010}
This CL adds IDL and mojo definition of reverse operator according to the spec issue [1] and implements it on DirectML backend. [1] webmachinelearning/webnn#773 Bug: 376707210 Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825 Commit-Queue: ningxin hu <ningxin.hu@intel.com> Auto-Submit: Shiyi Zou <shiyi.zou@intel.com> Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1382078}
Refactored "blink::DataTransfer" class to update "files_" member when it's DataObject's item list is changed, instead of doing the same in the files getter. This change ensures that files is updated immediately when the DataTransfer's item list changes. This fixes the issue where if a reference to DataTransfer.files is stored in a separate JS variable, then any file items added to that DataTransfer object are not reflected in the stored JS variable, until the DataTransfer object's files getter is invoked. The issue is not present in Safari and Firefox. Bug: 342067834 Change-Id: Id59ca73ae0e8b744b247f1eabba9f70565245433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5973363 Reviewed-by: Christine Hollingsworth <christinesm@chromium.org> Commit-Queue: Rohan Raja <roraja@microsoft.com> Reviewed-by: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/main@{#1382128}
This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf. Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby= Original change's description: > webnn: implement reverse operator > > This CL adds IDL and mojo definition of reverse operator according to > the spec issue [1] and implements it on DirectML backend. > > [1] webmachinelearning/webnn#773 > > Bug: 376707210 > Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b > Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825 > Commit-Queue: ningxin hu <ningxin.hu@intel.com> > Auto-Submit: Shiyi Zou <shiyi.zou@intel.com> > Reviewed-by: Austin Sullivan <asully@chromium.org> > Reviewed-by: ningxin hu <ningxin.hu@intel.com> > Cr-Commit-Position: refs/heads/main@{#1382078} Bug: 376707210 Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Owners-Override: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/main@{#1382142}
This method has been deprecated for dispatch() OBSOLETE_HISTOGRAMS=compute() is deprecated in favor of dispatch() Bug: 331351967 Change-Id: Id115f97edd78205c587b6920de4c21fa83961191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874875 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1382157}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )