This repository was archived by the owner on Dec 12, 2023. It is now read-only.
Add more php unit test cases and fix the php solution. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add reveseWordsInStringTest regarding interveiw description. - update revese-words-in-string code: need to trim the string.
- update sum-of-array-plus-one: change the name; format the code.
- add reveseWordsInStringTest regarding interveiw description. - update revese-words-in-string code: need to trim the string.
- update sum-of-array-plus-one: change the name; format the code.
blakeembrey
pushed a commit
that referenced
this pull request
Sep 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug:
reverse-words-in-string.php (according the description, the string need to be trimed.)
Format the code:
solutions/php/sum-of-array-plus-one.php
tests/php/factorialTest.php
Add unit test:
reverseWordsInStringTest.php
sumOfArrayPlusOneTest.php