Safari autoplay issue

[jacklinwood]

Hi Blake,

I wrote on a closed issue so not sure whether you see those anymore so though I'd try my luck here. Original message below:

Great plugin BTW :)

I am aware of the autoplay issue in Safari if the video is not muted. The default option is for the video to be muted but when inspecting the element, I can see that muted is not being added therefore it isn't working in Safari.

Any ideas?

[blakewilson]

Hey @jacklinwood ,

Sorry, I meant to get back to you on the original issue! This past week has been very crazy.

You are right. There is something going on with Safari not adding the attributes correctly.

This issue is happening around here:
https://github.com/blakewilson/vidbg/blob/master/src/vidbg.js#L146

I'm hoping to get this resolved this weekend!

Blake

[jacklinwood]

No need for an apology Blake. Just thought I'd try in case you hadn't seen it.

Great news on you hoping to get it sorted this weekend. Other than this small bug, it's the perfect plugin :)

Keep me posted!

Jack

[third-hyperion91]

Hi Blake! Great plugin, did you manage to sort the IOS safari issue? Thank you.

[blakewilson]

Hey all,

Sorry I'm late to get back on this.

I've found that in Safari, the autoplay attribute was interfering with the play promise that is used to autoplay video. Now, the plugin relies on the play promise (or lack thereof depending on the browser) to autoplay the video. There will be no side effects or visual changes with this approach, just a modification under the hood.

I've published a branch with this fix. Would you mind checking it out to make sure it resolves the problem you're facing before I merge into master?

Here's the branch:
https://github.com/blakewilson/vidbg/tree/safari-playback-fix

[third-hyperion91]

Great, thanks Blake! I will test it out when I get to my laptop and let you know! Wesley Earl | Front End Web Developer 01248 668194||wesley.earl@zipworld.co.uk COMPANY INFORMATION Zip World is a limited company registered in England and Wales with registered number 7777872 and VAT registered number 239173300. Our registered office is at Zip World Base Camp, Denbigh Street, Llanrwst, Conwy LL26 0LL ​ CONFIDENTIALITY NOTICE This message is intended solely for the addressee and may contain confidential information. If you have received this message in error, please send it back to us, and immediately and permanently delete it. Do not use, copy or disclose the information contained in this message or in any attachment. ​ PRIVACY POLICY AND TERMS OF USE For information about how we process data and monitor communications please see our Privacy Policy.

…

On Sun, 5 Apr 2020 at 07:43, Blake Wilson ***@***.***> wrote: Hey all, Sorry I'm late to get back on this. I've found that in Safari, the autoplay attribute was interfering with the play promise that is used to autoplay video. Now, the plugin relies on the play promise (or lack thereof depending on the browser) to autoplay the video. There will be no side effects or visual changes with this approach, just a modification under the hood. I've published a branch with this fix. Would you mind checking it out to make sure it resolves the problem you're facing before I merge into master? Here's the branch: https://github.com/blakewilson/vidbg/tree/safari-playback-fix — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO7H2PBCWXRPROIJZ2L2A2TRLASCXANCNFSM4LNTMZFQ> .

[jacklinwood]

Worked for me Blake!

Thanks a lot!

[blakewilson]

@jacklinwood great! I'll get it merged into master.

[blakewilson]

Here is the new version (2.0.1) with the Safari fix.

https://github.com/blakewilson/vidbg/releases/tag/v2.0.1

Take care!