-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict prerelease version to prerelease ranges #18
base: master
Are you sure you want to change the base?
Conversation
Sry for the delay, looks good but i have to check this first. |
Since semver itself doesn't specify range semantics and node-semver is probably the most widely known implementation of semver that implements ranges, I think it makes sense to follow it. That is the behaviour I would expect, at least. |
Looks like there's a 2 year old issue to make it official - semver/semver#205 |
It took some time since i had to verify this is fully compliant. To verify this, is used the script version of node-semver, not the cli version |
http://semver.org/#spec-item-9
Emphasis mine |
What is the status for this feature? I'm facing same issue. I didn't try with this pull request yet.
|
I'm currently working on a rework of the range system which allows us to support this kind of special semantic and most of node-semvers operators. Expect it in the next 2-4 weeks |
Currently prerelease versions like
1.2.5-beta
are matched successfully against non-prerelease ranges like>= 1.2.0
. This may cause undesired behavior and/or unexpected instability.This change is to restrict prerelease matches to more closely follow npm-semver:
https://github.com/npm/node-semver#prerelease-tags