Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict prerelease version to prerelease ranges #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 18 additions & 3 deletions range.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,15 @@ type versionRange struct {

// rangeFunc creates a Range from the given versionRange.
func (vr *versionRange) rangeFunc() Range {
return Range(func(v Version) bool {
return vr.c(v, vr.v)
})
if len(vr.v.Pre) == 0 {
return Range(func(v Version) bool {
return len(v.Pre) == 0 && vr.c(v, vr.v)
})
} else {
return Range(func(v Version) bool {
return prMatch(vr.v, v) && vr.c(v, vr.v)
})
}
}

// Range represents a range of versions.
Expand Down Expand Up @@ -187,6 +193,15 @@ func splitAndTrim(s string) (result []string) {
return
}

// When checking prerelease ranges, we want to make sure we're
// only matching against ranges with same [major, minor, patch]
func prMatch(v, o Version) bool {
return len(o.Pre) == 0 || (
v.Major == o.Major &&
v.Minor == o.Minor &&
v.Patch == o.Patch)
}

// splitComparatorVersion splits the comparator from the version.
// Spaces between the comparator and the version are not allowed.
// Input must be free of leading or trailing spaces.
Expand Down
12 changes: 12 additions & 0 deletions range_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ func TestParseRange(t *testing.T) {
{"1.2.2", false},
{"1.2.3", false},
{"1.2.4", true},
{"1.2.5-beta", false},
}},
{">=1.2.3", []tv{
{"1.2.3", true},
Expand Down Expand Up @@ -304,6 +305,17 @@ func TestParseRange(t *testing.T) {
{"1.2.3", false},
{"1.2.4", true},
}},

// Prerelease Expression
{">=1.4.2-beta.2", []tv{
{"1.3.2", false},
{"1.4.3", true},
{"1.4.0-beta", false},
{"1.4.2-beta", false},
{"1.4.2-beta.3", true},
{"1.4.3-beta", false},
}},

// Simple Expression errors
{">>1.2.3", nil},
{"!1.2.3", nil},
Expand Down