Made ggev functions as non-scalar functions and support for lapack-src v0.13 #28
Conversation
|
I have also changed to argument case to lower. Check if it is okay? Other alternative is to ignore case |
…lsame Arguments are now in lower case alpha in larfg is corrected as a scalar
|
@IvanUkhov - I was facing issue with |
bin/generate.py
Outdated
| @@ -190,15 +201,15 @@ def format_body(f): | |||
| def format_header_arguments(f): | |||
| s = [] | |||
| for arg in f.args: | |||
| s.append('{}: {}'.format(arg[0], translate_argument(*arg, f=f))) | |||
| s.append('{}: {}'.format(arg[0].lower(), translate_argument(*arg, f=f))) | |||
There was a problem hiding this comment.
I added tolower for all the arguments because there were too many warnings. I am also not sure if this is needed here as well.
If you dislike the idea of tolower, then we should add the ignore.
There was a problem hiding this comment.
This is a good thing to lowercase. In this high-level crate, we want to see Rust-friendly names.
It actually made me realize that the logic in generate.py is broken, as it assumes everything is lowercase. I’ll push a fix.
There was a problem hiding this comment.
Thanks. And let me know if you need me to change something. Waiting for your publish to crates.io
|
I propose to just skip |
|
It’s getting too big. I’ll merge this, and any other problems will be solved in separate pull requests. |
|
Thanks for merging. |
Made ggev functions as non-scalar functions and support for lapack-src v0.13
#27