Enhanced error reporting + client IP forwarding #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReissmueller
requested changes
Jan 8, 2021
| @@ -62,6 +62,11 @@ public function apiRequest($function, array $params = [], $session_id = null) | |||
| // Create SOAP connection | |||
| ini_set('default_socket_timeout', 5000); | |||
|
|
|||
| $headers = [ | |||
| 'Abort-On: error', | |||
| 'X-Forwarded-For: ' . $this->getFromContainer('requestor')->ip_address | |||
There was a problem hiding this comment.
Testing is our friend. This method is only defined in classes the use the Container trait. So at the top of the file add
use Blesta\Core\Util\Common\Traits\Container;
And at the top of the class add
use Container;
There are many classes in Blesta that already load this trait (models, controllers, and classes that extend Plugin, Module, and Gateway) but this file is not one of them.
There was a problem hiding this comment.
Testing is our friend.
Mea culpa. Updated.
…d halt execution which requires traversal to ascertain root cause that is outside the responsibilities of any module. Now, errors encountered during site management immediately bubble up Pass client IP address to ApisCP for auth logging. Requires additional configuration in [core] => http_trusted_forward in panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings two changes, the first of which is intended to disinter the root cause of a site creation failure. Second allows auth sharing for other areas, such as rampart:unban that, when called, would allow a client to unblock their IP address within Blesta.
Abort operation whenever an error is raised. Prior, only a fatal would halt execution which requires traversal to ascertain root cause that is outside the responsibilities of any module. Now, errors encountered during site management immediately bubble up
Pass client IP address to ApisCP for auth logging. Requires additional configuration in [core] => http_trusted_forward in panel