Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support network volumes, skip default models #16

Merged
merged 5 commits into from
Feb 20, 2024
Merged

feat: support network volumes, skip default models #16

merged 5 commits into from
Feb 20, 2024

Conversation

Meptl
Copy link
Contributor

@Meptl Meptl commented Dec 19, 2023

Motivation

  • Allows the use of models outside of the ones built into the image
  • Optionally reduces image size using a build flag

Issues closed

#1 #6

Meptl
Meptl commented Dec 19, 2023
View reviewed changes
src/extra_model_paths.yaml Outdated Show resolved Hide resolved
Meptl
Meptl commented Dec 19, 2023
View reviewed changes
Dockerfile Show resolved Hide resolved
@TimPietrusky
Copy link
Member

@Meptl thanks for providing this PR.

We will do a review & test and come back to you.

@TimPietrusky TimPietrusky self-requested a review December 20, 2023 12:42
@TimPietrusky TimPietrusky changed the base branch from main to dev February 20, 2024 08:30
@TimPietrusky TimPietrusky mentioned this pull request Feb 20, 2024
Closed
@TimPietrusky TimPietrusky merged commit 83caf92 into blib-la:dev Feb 20, 2024
@TimPietrusky TimPietrusky changed the title Support network volumes feat: support network volumes, skip default models Feb 20, 2024
TimPietrusky added a commit that referenced this pull request Feb 20, 2024
@Meptl @TimPietrusky
feat: support network volumes, skip default models (#16)
e4276de 
* Support network volumes

* README tweaks

* docs: added comment on what is happening

* feat: don't overwrite the default paths, but add "runpod_worker_comfy" to have additional paths

* docs: updated "bring your own models"

---------

Co-authored-by: Tim Pietrusky <timpietrusky@gmail.com>
@TimPietrusky
Copy link
Member

@Meptl thanks for putting your work into this.

The new image will soon be available in our dev

TimPietrusky added a commit that referenced this pull request Jun 4, 2024
@TimPietrusky @Meptl
feat: network-volume; execution time config; skip default images; acc…
070cde5 
…ess ComfyUI via web (#35)

* feat: provide option to run the handler locally as API

* ci: run the workflow on our extended instance

* feat: the local API should run on 0.0.0.0

* feat: make the image smaller

* ci: use semantic-version to create releases automatically

* chore: we don't want to break anyone with a minor release

* docs: added section for local API testing

* ci: use custom runner

* fix: added .releaserc, otherwise semantic-release will complain about a missing "package.json"

* feat: support network volumes, skip default models (#16)

* Support network volumes

* README tweaks

* docs: added comment on what is happening

* feat: don't overwrite the default paths, but add "runpod_worker_comfy" to have additional paths

* docs: updated "bring your own models"

---------

Co-authored-by: Tim Pietrusky <timpietrusky@gmail.com>

* feat: provide access to ComfyUI via web

* fix: use the full path to the output image

* feat: added env vars COMFY_POLLING_INTERVAL_MS and COMFY_POLLING_MAX_RETRIES

* test: added "subfolder"

* docs: update CUDA guide for Ubuntu

* feat(network-volume): added "custom_nodes"

* chore: removed lora from civitai

* docs: removed lora from civitai

* docs: simplified multiple sections; added an image to describe how to find the endpointID

* feat: remove "custom_nodes"

* feat: move models before python installation

* feat: added "runpod-volume"; use "dev" instead of "latest"

* docs: removed "custom nodes"; fixed links to GitHub Actions

* docs: fixed typo in GitHub

* docs: fixed hosts for local testing

* docs: updated link to docs from RunPod to create a network volume

* feat: expose the port of ComfyUI

* docs: fixed example link to download sdxl-turbo; removed nodes from network volume

* docs: moved example response into their own block

* chore: added example workflows for webp and sdxl-turbo

---------

Co-authored-by: Meptl <git-client@meptl.com>
TimPietrusky pushed a commit that referenced this pull request Jun 4, 2024
@semantic-release-bot
chore(release): 2.2.0
46474ac 
# [2.2.0](2.1.3...2.2.0) (2024-06-04)

### Bug Fixes

* don’t persist credentials ([1546420](1546420))
* use custom GITHUB_TOKEN to bypass branch protection ([9b6468a](9b6468a))

### Features

* network-volume; execution time config; skip default images; access ComfyUI via web ([#35](#35)) ([070cde5](070cde5)), closes [#16](#16)
github-actions bot pushed a commit to alka7ex/runpod-worker-comfy that referenced this pull request Sep 7, 2024
@semantic-release-bot
chore(release): 1.0.0
e8e2657 
# 1.0.0 (2024-09-07)

### Bug Fixes

* check_server default values for delay and check-interval ([4945a9d](4945a9d))
* don’t persist credentials ([1546420](1546420))
* don't run ntpdate as this is not working in GitHub Actions ([2f7bd3f](2f7bd3f))
* got rid of syntax error ([c04de4d](c04de4d))
* images in subfolders are not working, fixes [blib-la#12](https://github.com/alka7ex/runpod-worker-comfy/issues/12) ([37480c2](37480c2))
* path should be "loras" and not "lora" ([8e579f6](8e579f6))
* removed xl_more_art-full_v1 because civitai requires login now ([2e8e638](2e8e638))
* return the output of "process_output_image" and access jobId correctly ([blib-la#11](https://github.com/alka7ex/runpod-worker-comfy/issues/11)) ([dc655ea](dc655ea))
* **semantic-release:** added .releaserc ([blib-la#21](https://github.com/alka7ex/runpod-worker-comfy/issues/21)) ([12b763d](12b763d))
* updated path to "comfyui" ([37f66d0](37f66d0))
* use custom GITHUB_TOKEN to bypass branch protection ([9b6468a](9b6468a))

### Features

* add ComfyUI-IDM-VTON custom node ([180e6fb](180e6fb))
* add ComfyUI-IDM-VTON custom node ([9c9d6c5](9c9d6c5))
* added default ComfyUI workflow ([fa6c385](fa6c385))
* added FLUX.1 schnell & dev ([9170191](9170191))
* added runpod as local dependency ([9deae9f](9deae9f))
* added unit tests for everthing, refactored the code to make it better testable, added test images ([a7492ec](a7492ec))
* added xl_more_art-full_v1, improved comments ([9aea8ab](9aea8ab))
* base64 image output ([blib-la#8](https://github.com/alka7ex/runpod-worker-comfy/issues/8)) ([76bf0b1](76bf0b1))
* change the runner ([1707e16](1707e16))
* example on how to configure the .env ([4ed5296](4ed5296))
* image-input, renamed "prompt" to "workflow", added "REFRESH_WORKER" ([blib-la#14](https://github.com/alka7ex/runpod-worker-comfy/issues/14)) ([5f5e390](5f5e390))
* logs should be written to stdout so that we can see them inside the worker ([fc731ff](fc731ff))
* network-volume; execution time config; skip default images; access ComfyUI via web ([blib-la#35](https://github.com/alka7ex/runpod-worker-comfy/issues/35)) ([070cde5](070cde5)), closes [blib-la#16](https://github.com/alka7ex/runpod-worker-comfy/issues/16)
* run the worker locally ([blib-la#19](https://github.com/alka7ex/runpod-worker-comfy/issues/19)) ([34eb32b](34eb32b))
* simplified input ([35c2341](35c2341))
* simplified input to just have "prompt", removed unused code ([0c3ccda](0c3ccda))
* support sd3 ([blib-la#46](https://github.com/alka7ex/runpod-worker-comfy/issues/46)) ([dde69d6](dde69d6))
* updated path to "comfyui", added "ntpdate" to have the time of the container in sync with AWS ([2fda578](2fda578))
* use local ".env" to load env variables, mount "comfyui/output" to localhost so that people can see the generated images ([aa645a2](aa645a2))
* use models from huggingface, not from local folder ([b1af369](b1af369))
* wait until server is ready, wait until image generation is done, upload to s3 ([ecfec13](ecfec13))

### BREAKING CHANGES

* we have 3 different images now instead of just one: base, sdxl and sd3

* ci: use branch name for creating dev releases

* ci: replace "/" with "-" to have a valid tag name

* ci: correctly handle the tag  name

* ci: build an image that contains sd3 using docker bake

* ci: use "set" instead of "args"

* ci: use "env" instead of "set"

* ci: use variables instead of args

* ci: set variables directly for the targets

* ci: write the secrets into the GITHUB_ENV

* ci: handle env variables correctly

* ci: use env variables from GitHub Variables

* ci: added back to env

* ci: print out env

* ci: adding the vars directly into the workflow

* ci: example workflow for sd3

* ci: renamed DOCKERHUB_REPO to DOCKERHUB_REPOSITORY

* ci: removed quotes for DOCKERHUB_REPOSITORY

* ci: only use DOCKERHUB_REPO in bake

* ci: added vars into sd3 target

* ci: added direct target

* ci: back to basics

* ci: multi-stage build to not expose the HUGGINGFACE_ACCESS_TOKEN

* ci: write everything into GITHUB_ENV again

* ci: use correct name for final stage

* ci: use correct runner

* fix: make sure to use the latest versions of all packages

* ci: simplified variables for all targets

* docs: added 3 images, updated build your own image

* docs: updated TOC

* ci: updated name

* ci: use docker bake to publish 3 images instead of just 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimPietrusky TimPietrusky Awaiting requested review from TimPietrusky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meptl @TimPietrusky