dwim operations with grep -rnH do not work #95
Comments
pierre-rouleau
changed the title
bling
pushed a commit
that referenced
this issue
Jan 11, 2023
* Describe dwim with grep limitation. +1 optimization. * Add fzf-find-in-buffer (by LiuYinCarl) Add fzf-find-in-buffer originally proposed by LiuYinCarl in #94 I modified the proposed code a little to adapt to the current code and added protection against trying to search in a buffer that is not visiting a file, an prompt to save the buffer if it has been modified. * Fix issue #95: dwim with grep A work-around fix for dwim operations using grep. When a FZF grep with specified text is executed, a file pattern of " *" is automatically appended to the grep command, allowing the operation to proceed.
|
The latest pushed code fixes the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I wonder if something broke recently or if that ever worked, but when one of the
fzf-grep-dwimorfzf-grep-dwim-with-narrowingis used whilefzf/grep-commanduses grep (as opposed to rg) the operation does not work.The reason it does not work is the grep command requires a file pattern to search otherwise it searches from its stdin. The 'dwim' commands provide a pattern that the command can append to
fzf/grep-commandbut grep does not see any file pattern. So the grep operation fails. If we changefzf/grep-commandto use rg (ripgrep) then it works because ripgrep recusively searches all files (except the hidden ones) by default.So... I wonder... Did these dwim commands ever worked with 'grep -rnH' , or did I break something?
@bling, do you know?
The text was updated successfully, but these errors were encountered: