Removed buggy line-break behavior on emacs over terminal #27
Conversation
|
I have added another change to my |
|
Another update, i have changed the type of the var |
| (make-term "fzf" fzf/executable)) | ||
| (switch-to-buffer buf) | ||
| (linum-mode 0) | ||
| (set-window-margins nil 1) | ||
| ;;(set-window-margins nil 1) |
There was a problem hiding this comment.
it appears this would fix #26 as well....if you don't notice anything bad let's just remove it altogether and we're good to merge. thanks.
There was a problem hiding this comment.
I have been using like this for some days now and it's working fine. But I am only using emacs from terminal, so I am not aware of the implications on the x gui version. Please notice that I was working on some another features as well on this branch, maybe you will want one "clean" branch with only this change.
There was a problem hiding this comment.
either's fine, since without this change removed your PR wouldn't work anyways, right?
There was a problem hiding this comment.
Yes, that's right
(set-window-margins nil 1)Was causing unexpected and buggy parsing of line breaks over the output of fzf: https://i.imgur.com/UC0EUKq.png