Fix fzf/position-bottom defcustom type declaration bug & fix byte compiler warnings #83
Conversation
…s customization to work properly.
|
The fixed reference to free variable is what it says it is: just a fix to prevent the warning. However this code looks suspicious and should probably be changed. |
|
@bling, you may want to take a look at lispy to help you write lisp code. Trailing closing parens in separate lines in lisp code is not the style you should use. |
The setq-local macro accepts only one pair of parameters until it was changed in Emacs 27 to support multiple pairs. Since the file states it requires emacs 24.4, then the code must use the form that was available then and which is still valid. There is no performance issue in this code to justify using the newer form.
- Fix the Unused lexical variable ‘err’ warning. - Provide an error message that has more info. - Cleanup lisp syntax (just for that function): no closing parens on lines
this is due to multiple contributions from different people. if you want the entire file to be consistent, please open a separate PR independent of the defcustom fix. thanks. |
|
@bling, I will first fix all byte compile warnings. I started with the defcustom error and then fixed several issues in that stream of pull request. There are some warnings that remain and I'll fix them as soon as I get some time. |
fzf.el:169:1:Warning: Unused lexical variable ‘term-exec-hook’
In fzf/start:
fzf.el:199:32:Warning: assignment to free variable
‘term-suppress-hard-newline’
In fzf/action-find-file-with-line:
fzf.el:217:18:Warning: ‘goto-line’ is for interactive use only; use
‘forward-line’ instead.
In end of data:
fzf.el:453:1:Warning: the following functions are not known to be defined: turn-off-evil-mode,
term-char-mode, projectile-project-root
pierre-rouleau
changed the title
|
@bling, I fixed all byte compiler warnings as detected by Emacs 26.3 . I'll check with Emacs 27 and 28 soon. |
pierre-rouleau
changed the title
|
@bling, would it be possible to merge in these PRs? I have found other warnings I'd like to push. I have also found a scenario where the lines returned by fzf includes trailing spaces which cause the use in Emacs to fail. I have fix for those as well. I will report this second issue as a bug and would like to provide a fix for that. Thanks! |
|
Thanks @bling ! |
Which prevented its customization to work properly.
There is no 'bool type. It's 'boolean.