Skip to content

fix: only update session cookie when changed #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: only update session cookie when changed #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-ladybugs-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@blinkk/root': patch
---

fix: only update session cookie when changed
6 changes: 6 additions & 0 deletions packages/root/src/middleware/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ export function sessionMiddleware(options?: SessionMiddlewareOptions) {
req.session = session;
res.session = session;
res.saveSession = (saveSessionOptions?: SaveSessionOptions) => {
if (!session.hasChanges) {
return;
}
// "secure" cookies require https, so disable "secure" when in development.
const secureCookie = Boolean(process.env.NODE_ENV !== 'development');
const cookieValue = session.toString();
Expand Down Expand Up @@ -54,6 +57,7 @@ export function sessionMiddleware(options?: SessionMiddlewareOptions) {

export class Session {
private data: Record<string, string> = {};
hasChanges = false;

constructor(data?: Record<string, string>) {
this.data = data || {};
Expand Down Expand Up @@ -82,10 +86,12 @@ export class Session {

setItem(key: string, value: string) {
this.data[key] = value;
this.hasChanges = true;
}

removeItem(key: string) {
delete this.data[key];
this.hasChanges = true;
}

toString(): string {
Expand Down