Skip to content

fix: synchronization issues in plugin goroutines on shutdown #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

fix: synchronization issues in plugin goroutines on shutdown #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pipeline/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package pipeline

import (
"fmt"
"sync"

"github.com/blinklabs-io/adder/event"
"github.com/blinklabs-io/adder/plugin"
Expand All @@ -29,6 +30,7 @@ type Pipeline struct {
outputChan chan event.Event
errorChan chan error
doneChan chan bool
wg sync.WaitGroup
}

func New() *Pipeline {
Expand Down Expand Up @@ -108,6 +110,7 @@ func (p *Pipeline) Start() error {
// Stop shuts down the pipeline and all plugins
func (p *Pipeline) Stop() error {
close(p.doneChan)
p.wg.Wait()
close(p.errorChan)
close(p.filterChan)
close(p.outputChan)
Expand All @@ -131,9 +134,11 @@ func (p *Pipeline) chanCopyLoop(
input <-chan event.Event,
output chan<- event.Event,
) {
p.wg.Add(1)
for {
select {
case <-p.doneChan:
p.wg.Done()
return
case evt, ok := <-input:
if ok {
Expand All @@ -146,9 +151,11 @@ func (p *Pipeline) chanCopyLoop(

// outputChanLoop reads events from the output channel and writes them to each output plugin's input channel
func (p *Pipeline) outputChanLoop() {
p.wg.Add(1)
for {
select {
case <-p.doneChan:
p.wg.Done()
return
case evt, ok := <-p.outputChan:
if ok {
Expand Down