Skip to content

Better coordinate handling #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Dec 19, 2018
Merged

Better coordinate handling #71

merged 29 commits into from
Dec 19, 2018

Conversation

y21
Copy link
Contributor

@y21 y21 commented Dec 19, 2018

Without this implementation the client emits coordinates every millisecond and the server emits an array with all blobs every 10 milliseconds which is heavily unefficient.
The client now only emits an event when the user changes the direction. It calculates the X/Y position by using the UNIX timestamp of when the direction was changed and where it was changed (coordinates).

y21 added 29 commits December 17, 2018 20:35
@y21
Add player structure
ad4415d
@y21
x/y get accessor
f323f81
@y21
comment ffaCoordinateChange out (debug)
276dfc9
@y21
Use Player class
1e29751
@y21
Don't emit blob objects every 10 ms
0e2d6b5
@y21
Use Player structure instead of raw object
d7b3eae
@y21
Don't assign values to coordinates
f6e683c
@y21
Direction bugfixes
5c18353
@y21
Make x/y properties get/set accessors
4e51d85
@y21
Add get/set accessors for x/y
965a8a1
@y21
Don't emit ffaDirectionChange in set accessor
bb0caf7
@y21
Fix directions and add ffaUserJoin
3a0951b
@y21
Emit ffaUserJoin event when user joins
d8ea733
@y21
Remove comment (debug)
78c0c4b
@y21
Don't emit socket#id
363d130
@y21
Prevent x accessor from returning <0 || >2000
7f2472c
@y21
Don't assign undefined to id
b1fca97
@y21
remove line
6d07804
@y21
also emit users
818057e
@y21
Prevent going from below 0
45ed0a9
@y21
display users that are already in FFA
5f375b1
@y21
Merge with server data
710b797
@y21
Decrease tick limit to 1.5 seconds
7d4ee5a
@y21
Because apparently Object.assign overrides the original object
b9bc38d
@y21
Don't display blobs more than once
374a350
@y21
Randomize new coordinates after getting nommed properly
387e700
@y21
Properly respawn client
4c644e2
@y21
Use reference variable for modifying properties
11c9f08
@y21
Don't process result twice
9ca098b
@y21 y21 added the bug Something isn't working label Dec 19, 2018
@y21 y21 added backend Relates to the backend major change Very important, and may contain breaking changes or a lot of additions labels Dec 19, 2018
@y21 y21 self-assigned this Dec 19, 2018
@y21 y21 merged commit 856dfed into master Dec 19, 2018
@y21 y21 mentioned this pull request Dec 19, 2018
Closed
@y21 y21 deleted the direction_events branch January 6, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@y21 y21

Labels
backend Relates to the backend bug Something isn't working major change Very important, and may contain breaking changes or a lot of additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@y21