Update searchQuery on input change to handle Enter key press correctly #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced @Bind with @oninput for searchQuery in the input field to ensure immediate update. - Added UpdateSearchQuery method to handle input changes. - Ensured searchQuery has the correct value when Enter key is pressed.
- Configure GitHub Actions to deploy Angor project to two different domains using separate branches. - Minify JS and CSS files before deployment. - Include `.nojekyll` and `CNAME` files for each domain. - Publish to `gh-pages-test` for test.angor.io and `gh-pages-beta` for beta.angor.io.
This reverts commit 6e10ac8.
dangershony
reviewed
Jun 10, 2024
dangershony
reviewed
Jun 10, 2024
|
Cypress regression tests are failing because they search for the theme icon to enable dark mode at the start of the run. @miladsoft , once you are done, I'll update the test to use a data-cy attribute and ensure there are no actions searching for a specific icon (as there shouldn't be any). |
fixed |
Implemented a new IconService class to dynamically handle SVG icons in the Angor App project. This service fetches SVG icons from the wwwroot/assets/icons folder, adjusts their size, and updates their stroke and fill colors as needed. Features: - Fetches SVG icons from the server dynamically based on icon name. - Adjusts the width and height of the SVG icons to specified dimensions. - Updates the stroke and fill colors of the SVG icons to the provided values. - Caches the icons for improved performance and reduced server requests. Benefits: - Centralized management of SVG icons, ensuring consistency across the application. - Enhanced performance through caching, reducing redundant server requests. - Improved flexibility in icon customization, allowing dynamic adjustments to icon size and colors. - Simplified code in components by offloading SVG handling to a dedicated service.
- Added all SVG icons in wwwroot/assets/icons as embedded resources. - Updated IconService to load icons from embedded resources. - Modified .csproj file to include SVG icons as embedded resources. - Improved performance and offline capabilities by eliminating server dependency for icons.
dangershony
reviewed
Jun 17, 2024
dangershony
reviewed
Jun 17, 2024
dangershony
reviewed
Jun 17, 2024
remove extra code:
builder.Services.AddScoped(sp => new HttpClient { BaseAddress = new Uri(builder.HostEnvironment.BaseAddress) });
dangershony
reviewed
Jun 17, 2024
dangershony
reviewed
Jun 17, 2024
dangershony
reviewed
Jun 17, 2024
dangershony
reviewed
Jun 17, 2024
dangershony
reviewed
Jun 17, 2024
src/Angor/Client/wwwroot/assets/img/mobile-installation-screenshot.png
Outdated
Show resolved
Hide resolved
about 5 kb |
Ok I suppose this is not a big deal |
|
@itailiors when you have a free moment check why the test fails and fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.