Adding support for mainnet #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public List<SettingsUrl> GetDefaultIndexerUrls() | ||
| { | ||
| return new List<SettingsUrl> | ||
| if (currentNetwork.NetworkType == NetworkType.Testnet) |
There was a problem hiding this comment.
Why not just replace the subdomain in the URL if the rest stays the same?
There was a problem hiding this comment.
it may not always be the case, it is just simpler this way.
| <div class="mb-3"> | ||
| <label for="networkSelection">Select Network:</label> | ||
| <select class="form-control" id="networkSelection" @bind="selectedNetwork"> | ||
| <option value="testnet" selected>Testnet</option> |
There was a problem hiding this comment.
Could this be data driven from the network configuration class?
There was a problem hiding this comment.
It can but I think it is not urgent rn, we will for now just have main/test.
DavidGershony
approved these changes
Mar 29, 2024
DavidGershony
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Adding support for mainnet * show error if getting test coins failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR is pushed we should create a mainnet Angor key
The logic in going to mainnet or testnet is dependent on the url of the domain.
If it contains "test" or "localhost" the app will default to testnet otherwise mainnet.
However it is possible to force a network in the settings page.