Unit tests for walletOperations, and cypress test #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funds are null
not sure about the values, @dangershony can you check if the logic is ok?
|
Unit Tests for WalletOperations: Added tests for wallet word generation, transaction handling with sufficient and insufficient funds, unspent output retrieval, and transaction fee calculation. Cypress Tests : added a test for browse a project, and then invest |
itailiors
commented
May 22, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void CalculateTransactionFee_WithMultipleScenarios() |
There was a problem hiding this comment.
@dangershony glad if you could go over the logic of this test,
mostly on the values, and if there is no need for Assert.Equal(0.00000001m, calculatedFeeSufficient);
dangershony
reviewed
May 23, 2024
| // Act & Assert for sufficient funds | ||
| var calculatedFeeSufficient = walletOperations.CalculateTransactionFee(sendInfoSufficientFunds, accountInfo, feeRate); | ||
| Assert.True(calculatedFeeSufficient > 0); | ||
| Assert.Equal(0.00000001m, calculatedFeeSufficient); // Assuming an expected fee for validation |
There was a problem hiding this comment.
this is fine, the fee is exactly the same every time because the size of the trx is fixed and feerate is fixed, so it is fine to keep it.
dangershony
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.