Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tx stall #178

Merged
merged 2 commits into from
May 16, 2019
Merged

Fix/tx stall #178

merged 2 commits into from
May 16, 2019

Conversation

lnbc1QWFyb24
Copy link
Collaborator

Closes #177

@lnbc1QWFyb24 lnbc1QWFyb24 added the bug Something isn't working label May 15, 2019
@lnbc1QWFyb24 lnbc1QWFyb24 requested a review from cmeisl May 15, 2019 06:42
@lnbc1QWFyb24 lnbc1QWFyb24 self-assigned this May 15, 2019
@cmeisl cmeisl merged commit 45c252d into develop May 16, 2019
@cmeisl cmeisl deleted the fix/tx-stall branch May 16, 2019 01:50
cmeisl added a commit that referenced this pull request May 16, 2019
* Fix/tx stall (#178)

* fixed bug where txStall event would be fired when the transaction has not stalled

* added check for status approved

* Fix race condition (#175)

* Fix/promievent (#180)

* fixed bug where txStall event would be fired when the transaction has not stalled

* added check for status approved

* resolve with promiEvent

* cloned inner object from contract method call (#182)

* Fix Duplicate Transaction Check (#184)

* added extra check for confirmed

* dont remomve from queue

* add on confirmation method (#186)

* Test truffle contract decoration (#176)

* Test contract decoration matches snapshot

* Update yarn.lock

* Improve Contract test coverage

* Classify existing Contract tests as unit tests

* Run contract tests with multiple web3 versions

* Clear localStorage between contract tests

* Improve comment

* Remove redundant comment

* Mock websocket in contract test

* Remove mock-socket from contract tests

* Only snapshot test a subset of decoratedContract

* Remove redundant logic

* Mock the web3 websocket connection

* Cleanup

* Use a complex ABI for contract decoration tests

* Refactor contract delegation for web3 >beta.37

* Improve comments

* Hardcode userAgent in tests

* Setup a ganache instance for use in the test env

* Improve ganache error handling

* Create web3.js test structure

* - Add test for web3Func bigNumber
- Add test for web3Func gasPrice

* Handle restarting ganache when jest is watching

* Add test for web3Funcs.contractGas

* Set ganache account generation to be deterministic

* - Add test for web3Func txGas
- Add test for web3Func balance
- Add test for web3Func accounts
- Add test for web3Func txReceipt

* Create ganacheConfig.js

* Deploy contract to testing ganache chain

* Remove redundant console.log

* Add truffle-contract dependency

* Change the contract deployed to test ganache chain

* Test estimating gas of a truffle method call

* Reduce logic duplication

* Improve comments

* Explicitly end tests once ganache is shutdown

* Fix estimateGas on truffle contract methods

* Test truffle contract decoration

* Update snapshot

* return promievent frim sendTransaction (#187)

* update to version 0.7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txStall event is fired when a transaction hasn't stalled
2 participants