return promievent frim sendTransaction #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeisl
approved these changes
May 16, 2019
cmeisl
approved these changes
May 16, 2019
cmeisl
added a commit
that referenced
this pull request
May 16, 2019
* Fix/tx stall (#178) * fixed bug where txStall event would be fired when the transaction has not stalled * added check for status approved * Fix race condition (#175) * Fix/promievent (#180) * fixed bug where txStall event would be fired when the transaction has not stalled * added check for status approved * resolve with promiEvent * cloned inner object from contract method call (#182) * Fix Duplicate Transaction Check (#184) * added extra check for confirmed * dont remomve from queue * add on confirmation method (#186) * Test truffle contract decoration (#176) * Test contract decoration matches snapshot * Update yarn.lock * Improve Contract test coverage * Classify existing Contract tests as unit tests * Run contract tests with multiple web3 versions * Clear localStorage between contract tests * Improve comment * Remove redundant comment * Mock websocket in contract test * Remove mock-socket from contract tests * Only snapshot test a subset of decoratedContract * Remove redundant logic * Mock the web3 websocket connection * Cleanup * Use a complex ABI for contract decoration tests * Refactor contract delegation for web3 >beta.37 * Improve comments * Hardcode userAgent in tests * Setup a ganache instance for use in the test env * Improve ganache error handling * Create web3.js test structure * - Add test for web3Func bigNumber - Add test for web3Func gasPrice * Handle restarting ganache when jest is watching * Add test for web3Funcs.contractGas * Set ganache account generation to be deterministic * - Add test for web3Func txGas - Add test for web3Func balance - Add test for web3Func accounts - Add test for web3Func txReceipt * Create ganacheConfig.js * Deploy contract to testing ganache chain * Remove redundant console.log * Add truffle-contract dependency * Change the contract deployed to test ganache chain * Test estimating gas of a truffle method call * Reduce logic duplication * Improve comments * Explicitly end tests once ganache is shutdown * Fix estimateGas on truffle contract methods * Test truffle contract decoration * Update snapshot * return promievent frim sendTransaction (#187) * update to version 0.7.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180