Update - Tx Boost URL to non-alpha, OKX wallet available on all devices #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
changed the title
1 task
cmeisl
approved these changes
Sep 7, 2023
| @@ -156,15 +156,15 @@ type Chain = { | |||
| namespace?: 'evm' // string indicating chain namespace. Defaults to 'evm' but will allow other chain namespaces in the future | |||
| // PLEASE NOTE: Some wallets require an rpcUrl, label, and token for actions such as adding a new chain. | |||
| // It is recommended to include rpcUrl, label, and token for full functionality. | |||
| rpcUrl?: string // Recommended to include. Used for network requests. | |||
| rpcUrl?: string // Recommended to include. Used for network requests (eg Alchemy or Infura end point). | |||
There was a problem hiding this comment.
Why are other companies specifically called out? Are devs confused by what this value should be?
There was a problem hiding this comment.
This note was originally made to the core README was made in response to a pull request by Alchemy. It provides clarity that Alchemy's RPC can be used as an alternative to Infura in our examples. Rather than adding Alchemy's RPC to all examples and quickstarts, we wanted users to know that both Alchemy and Infura are valid RPC providers for W3O, ensuring flexibility and provider-agnostic compatibility. I updated the whole Chain type here to ensure they were aligned.
This was referenced Sep 8, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Tx_boost (transaction protection) to the non-alpha url
Update OKX wallet to be available on all devices - Closes: #1900
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors