Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Missing MainnetInfuraNetwork #9

Closed
abdulowork opened this issue Jan 27, 2018 · 6 comments · Fixed by #35
Closed

Missing MainnetInfuraNetwork #9

abdulowork opened this issue Jan 27, 2018 · 6 comments · Fixed by #35
Assignees
Labels
Projects

Comments

@abdulowork
Copy link
Contributor

Use SimpleNetwork object as an implementation of Network protocol in MainnetInfuraNetwork. Create SimpleNetwork inside MainnetInfuraNetwork instead of passing it as a dependency.

@rockfridrich
Copy link
Member

Can you reference an Example how decorator should be implemented?

@abdulowork
Copy link
Contributor Author

@rockfridrich I just figured I was thinking about encapsulating SimpleNetwork instead of decorating it. See how RLPCollectionsAppendix and RLPBytesAppendix encapsulate RLPStandardAppendix in case you need a reference.

@abdulowork abdulowork changed the title Implement MainnetInfuraNetwork as a decorator of SimpleNetwork Missing MainnetInfuraNetwork Feb 19, 2018
@0crat 0crat added the scope label Feb 19, 2018
@0crat
Copy link

0crat commented Feb 19, 2018

The job #9 assigned to @rockfridrich/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this. @rockfridrich/z is not a member of this project yet, but they can request to join. Check your profile and follow the instructions.

@0crat
Copy link

0crat commented Feb 19, 2018

Bug was reported, see §29: +15 points just awarded to @Biboran/z, total is +75

@0crat
Copy link

0crat commented Feb 19, 2018

Manual assignment of issues is discouraged, see §19: -5 points just awarded to @Biboran/z, total is +75

@rockfridrich rockfridrich added this to To do in Alpha via automation Feb 19, 2018
@rockfridrich rockfridrich moved this from To do to In progress in Alpha Feb 19, 2018
Alpha automation moved this from In progress to Done Feb 20, 2018
@0crat
Copy link

0crat commented Feb 20, 2018

Order was finished, quality was "acceptable": +30 points just awarded to @rockfridrich/z, total is +30

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Alpha
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants