Bump class-transformer and apply ClassSerializerInterceptor globally

[pbn4]

Pull Request Template

Issue

Addresses # (#1131)

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

This PR removes user and listing joins from application service query calls. @RelationId is used to expose foreign key id and use that directly to construct DTO response.

There was one problem with this approach though, I was not able to expose getter within DTOs. Turns out DTOs in our API were not serialized with class-transformer, they were returned as class instances from the api so basic JSON.stringify was applied to them instead of class-transformers method serialize. This PR changes with applying ClassSerializerInterceptor globally to every controller.

NOTE: This change requires DB reseed because there was also a problem with application preference options seed definition, it was not serializable.

Apache benchmark tests for /applications endpoint before the change:

➜  core git:(master) ✗ ab -k -c 10 -n 1000 localhost:3100/applications                           [05/25/21|5:12:13]
This is ApacheBench, Version 2.3 <$Revision: 1879490 $>
Copyright 1996 Adam Twiss, Zeus Technology Ltd, http://www.zeustech.net/
Licensed to The Apache Software Foundation, http://www.apache.org/

Benchmarking localhost (be patient)
Completed 100 requests
Completed 200 requests
Completed 300 requests
Completed 400 requests
Completed 500 requests
Completed 600 requests
Completed 700 requests
Completed 800 requests
Completed 900 requests
Completed 1000 requests
Finished 1000 requests


Server Software:
Server Hostname:        localhost
Server Port:            3100

Document Path:          /applications
Document Length:        49090 bytes

Concurrency Level:      10
Time taken for tests:   48.587 seconds
Complete requests:      1000
Failed requests:        0
Keep-Alive requests:    1000
Total transferred:      49339000 bytes
HTML transferred:       49090000 bytes
Requests per second:    20.58 [#/sec] (mean)
Time per request:       485.869 [ms] (mean)
Time per request:       48.587 [ms] (mean, across all concurrent requests)
Transfer rate:          991.68 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        0    0   0.0      0       0
Processing:    97  484 174.8    434    1313
Waiting:       97  484 174.8    434    1313
Total:         98  484 174.8    434    1313

Percentage of the requests served within a certain time (ms)
  50%    434
  66%    497
  75%    548
  80%    589
  90%    721
  95%    850
  98%   1006
  99%   1158
 100%   1313 (longest request)

and after the change:

➜  core git:(typeorm_optimization_2) ✗ ab -k -c 10 -n 1000 localhost:3100/applications           [05/25/21|5:14:06]
This is ApacheBench, Version 2.3 <$Revision: 1879490 $>
Copyright 1996 Adam Twiss, Zeus Technology Ltd, http://www.zeustech.net/
Licensed to The Apache Software Foundation, http://www.apache.org/

Benchmarking localhost (be patient)
Completed 100 requests
Completed 200 requests
Completed 300 requests
Completed 400 requests
Completed 500 requests
Completed 600 requests
Completed 700 requests
Completed 800 requests
Completed 900 requests
Completed 1000 requests
Finished 1000 requests


Server Software:
Server Hostname:        localhost
Server Port:            3100

Document Path:          /applications
Document Length:        49620 bytes

Concurrency Level:      10
Time taken for tests:   34.728 seconds
Complete requests:      1000
Failed requests:        0
Keep-Alive requests:    1000
Total transferred:      49869000 bytes
HTML transferred:       49620000 bytes
Requests per second:    28.80 [#/sec] (mean)
Time per request:       347.275 [ms] (mean)
Time per request:       34.728 [ms] (mean, across all concurrent requests)
Transfer rate:          1402.35 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        0    0   0.0      0       0
Processing:   142  345  54.0    342     594
Waiting:      141  345  54.0    342     594
Total:        142  345  54.0    342     595

Percentage of the requests served within a certain time (ms)
  50%    342
  66%    370
  75%    382
  80%    391
  90%    417
  95%    439
  98%    465
  99%    481
 100%    595 (longest request)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Prototype/POC (not to merge)
• This change is a refactor/address technical debt
• This change requires a documentation update
• This change requires a SQL Script

How Can This Be Tested/Reviewed?

Fetch /applications using postman and observer that DB queries are not joining listing and user table, but the response contains IdDto response for user and listing field.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have updated the changelog to include a description of my changes

[seanmalbert]

Hey @pbn4 ,

I like the updates here, with adding ClassSerializerInterceptor globally and the use of transform in particular. I have a couple of comments in applications.service.

Since reseeding was necessary to get this working, do you foresee issues with pushing this to staging/prod?

[netlify]

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: adb5751

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/60b0b0ca131a5d000800f4d6

😎 Browse the preview: https://deploy-preview-1265--clever-edison-cd22c1.netlify.app

[pbn4]

Hey @pbn4 ,

I like the updates here, with adding ClassSerializerInterceptor globally and the use of transform in particular. I have a couple of comments in applications.service.

Since reseeding was necessary to get this working, do you foresee issues with pushing this to staging/prod?

@seanmalbert good catch, see latest commit.