feat: new checkbox behavior #1272

emilyjablonski · 2021-05-26T17:45:26Z

Pull Request Template

Issue

Addresses #1229

This change addresses the issue in full
This change addresses only certain aspects of the issue
This change is a dependency for another issue
This change has a dependency from another issue

Description

The new OHA preference set has new "exclusive" options, meaning options that when checked should un-check all other boxes, and if checked must be the only checked box.

This logic somewhat already existed (although through this PR I found it was buggy) with the generic "no thanks" option that was default added to the end of every preference set. The bug on master was that if option D is the generic-exclusive-no-thanks checkbox, if you click A B C then D it will correctly uncheck A-C, but if you then click any of A-C with D selected both will be checked, which is incorrect. This PR solves that issue.

In a separate PR before this which is merged, I added the ability to not automatically include the default exclusive box (through the hideGenericDecline flag), since that isn't part of OHA.

This PR adds the exclusive flag on a preference option which indicates it has the exclusive behavior outlined above. There can be any number of exclusive options. I had to abstract out some of the functions I wrote/updated so that the logic could be shared between public and partners (we needed the logic in parters in the piece where you can edit applications manually).

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Prototype/POC (not to merge)
This change is a refactor/address technical debt
This change requires a documentation update
This change requires a SQL Script

How Can This Be Tested/Reviewed?

You will need to pull in the Coliseum listing, and check it out in public by going through the application process and checking/unchecking allllll the boxes. Then submit the application, head over to partners and edit it, and look at the checkboxes there for the same exclusive functionality on the last two options for OHA.

Checklist:

** I would love to be testing this change but we don't really have a way to do that yet. Just another push to add a unit test suite to the public and partners site.

netlify · 2021-05-26T17:48:58Z

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 6710877

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/60b03d29d51d530007bd698a

😎 Browse the preview: https://deploy-preview-1272--clever-edison-cd22c1.netlify.app

jaredcwhite

Just had one question regarding the refactor, otherwise LGTM.

On an infinite timescale, I'd love to discuss refactoring how the frontend is now handling preferences overall. My OOP-loving brain is really struggling with the verbosity and ceremony of all these functions passing low-level values back and forth as well as conditionals everywhere. I fear it won't be straightforward to maintain over the long term.

sites/partners/src/applications/PaperApplicationForm/sections/FormPreferences.tsx

emilyjablonski · 2021-05-26T23:38:26Z

I think in the long term we have hopefully a new application section for something like these "Programs" since these aren't really preferences. We kind of planned to work with what we already have in the short term but I almost wish we had just gone for a bigger change anyway. I definitely agree with you.

jaredcwhite · 2021-05-27T03:45:17Z

We kind of planned to work with what we already have in the short term but I almost wish we had just gone for a bigger change anyway.

Oh yeah, totally understandable to try to utilize what we have already set up and seems reasonable to me in the near term. I just think we'll want to be aware of the tech debt involved…

seanmalbert

@emilyjablonski ,

I'm not necessarily requesting changes, but I do have questions, that depending on the answer will require changes. Please see my comments in the code. My main question is around the handling of "normal" vs "exclusive" options. Can't the exclusive options be treated the same as normal options, aside from the "checking/unchecking" logic? With multiple exclusive options, won't we want to know which one of those was selected and even if there was just one exclusive option, does it hurt to save that as a normal option with this new setup?

seanmalbert · 2021-05-27T21:03:49Z

sites/partners/src/applications/PaperApplicationForm/sections/FormPreferences.tsx

+  const getExclusiveOption = (label: string, noneKey: string, preference: Preference) => {
+    return (
+      <Field
+        id={noneKey}
+        name={noneKey}
+        type="checkbox"
+        label={label}
+        register={register}
+        inputProps={{
+          onChange: (e) => {
+            if (e.target.checked) {
+              setExclusive(true, setValue, exclusiveKeys, noneKey, preference)
+            }
+          },
+        }}
+      />
+    )
+  }


I feel like I'm missing something, but does it make sense to start saving the value of the "none" checkboxes? In the case of Coliseum, and maybe future cases, wouldn't it be useful to know the distinction? Then the only real difference between these "none" types and the rest, would be with setExclusive, and a lot of this could be simplified.

Same goes for the public site's handling of this.

The distinctions between a normal and exclusive option if you look at the public implementation is the onChange, the validation, and the optional existence of both a description and a household member dropdown. I feel like it's cleaner to separate them out into two fxns than have one with an "if exclusive" in four places, but I don't feel strongly about this. And the values still get sent through the form, so I'm not sure what you mean by starting to save the values?

When I check "None of these preferences apply to me, but I would like to be considered" or "
I don't want to be considered for [housing authority] project-based voucher units" those values are not saved in the application.

Taking offline (online?)

sites/public/pages/applications/preferences/all.tsx

seanmalbert

Updates are looking good and not seeing any issues, thanks @emilyjablonski

@Transforms

* Removes BACKEND_API_BASE from partners netlify.toml (bloom-housing#1273) * updates pull request template * removes BACKEND_API_BASE from netlify.toml * Add icon support to standard variants of Button component (bloom-housing#1268) * Refactor icon placement in Button component * Update tests and icon placement styles for Button component * Add Icon Button PR to Changelog * Detect proper inline sizing for button * Remove explicit fill color from back arrow icon * fix: preference select text issues (bloom-housing#1270) * feat: new checkbox behavior (bloom-housing#1272) * Bump class-transformer and apply ClassSerializerInterceptor globally (bloom-housing#1265) * Bump class-transformer and apply ClassSerializerInterceptor globally * Switch back to nestjs/swagger@4.6.1 * Regenerate backend-swagger.ts client * Update changelog * Add missing typing to @Transforms * Fix linter * Define generic type for authorizeUserAction * Add a migration fixing extraData serialization problems for applications.preferences Co-authored-by: Bart <bart@barts-macbook-pro.home> * Ensure Netlify builds always do a full rebuild and deploy (bloom-housing#1279) * Fix/preference extradata (bloom-housing#1282) * Save an empty array if there is no extraData * Fixed broken test * Updated changelog * Fix all spec Co-authored-by: dominikx96 <dominik@airnauts.com> * Remove legacy tests sites/public/cypress/integration/pages/applications_new.ts * un-comment out income verification * add back in household validation * add back in live-alone validation * validation typo * comment out validations and the tests w feature flag todo * remove incorrect disclaimer URL check Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>

This reverts commit 1a1fab0.

@Transforms

* Remove /auth/register endpoint (#140) * late-breaking phone number fix for Jones (#156) * Add monarch listing (#131) * catch up ala site to upstream before Monarch launch (#158) * fix requested QA changes for Monarch (#157) * Fix QA request changes * fix quotes and ordinal on preferences * add listing-specific rentalAssistance text * update office hours for C19 * update rentalAssistance text for Monarch (#159) * apply conditional fix for requiredDocuments from upstream (#163) * Fix deposit for Monarch listing (#161) * Fix deposit for Monarch listing * Update leasing agent address * change monarch pref ordinals to numeric format (#164) * extend Skylyne deadline to 1 Nov per request (#165) * Re-create Re-create SMC Brunswick Listing (#168) * Initial Logan listing (#169) * Update ala feedback link (#170) * Another round of Logan listing QA (#173) * Another round of QA fixes for Logan (#175) * adjust Logan lat/lng for map display (#177) * Update Logan leasing agent number (#179) * fix 2 decimal points for deposit min/max on Logan * Extend skylyne again (#182) * update Skylyne deadline to 12/1 * add triton-test listing from core so automated tests can use it * Fixes for Netlify build * Update from main repo + Alameda * Update SJ subrepo * SMC subrepo update * Update missing changes for Alameda repo * Fix env jsonpaths for templates * Move SMC and SJ listings to backend core * Update application methods for SJ and SMC listings * Move SMC and SJ listings to backend core * Update listings to the new shema * Remove missing route from SJ * Remove additional resources reference from SJ * Hide links to sign in * Add So Hay listing * Update So Hay occupancy * SqFeet fix for So Hay * Add events to So Hay * Update So Hay due date * Fixes for Brunswick listing * 2021 changes for Brunswick * Adds cost not included to Brunswick * Another round of fixes for Brunswick * Update SoHay, add ami chart * So Hay updates with download links * Late January So-Hay update * Copy public-ala over to public * Remove ami_charts * Increase JS heap * Add a mandatory GET listings county query param * Remove housing counselors from next.config.js * Fix HousingCounselors.tsx export * Fix translations * Add housing counselors page * Apply heroku JS VM best practices for container memory size optimization * Increase server request/response timeout * Increase max_old_space_size * Optimize next.js /listings queries * Revert "Add a mandatory GET listings county query param" This reverts commit 9547714. * Add missing jsonpath package * Add Alameda Specific Translation to 0.3 Alameda * Fix PageHeader changes * Fix counselors build * Fix counselors noneFound logic * Fix counselors build * Align Alameda changes with prod * So Hay updates, add events and hide counselors * Update listing_data/so-hay.json * update general.json with text View Additional Housing Opportunities and Resources * removed the second sentence from Nav text * Make hero centered * Remove duplicate get assistance link * Update the Alameda string to not include log-in text * Skip some validations for SoHay listing * Fix So Hay preference format * Improve presentation of the Additional Resources page * Fix class names * Translations for City of Hayward preferences * Update Do You Work In sections * Add link for more mission corridor information * Add the translation to the override file and remove from ui-components * Changed Displaced to Displacee * Final round of updates for So Hay with main repo merge * Update lottery translation * Update lottery translation * Fix lottery translations * Fix SoHay CSVFormattingType in json seed * Switch off the houshold size validation for SoHay * Updated 211 translations * Hotfix CSV encoder * Clean up aside block styling and add missing mobile blocks (#1140) * Clean up aside block styling and add missing mobile blocks * Remove tinting from Open Housts section * Add mercy listing (#259) * Initial Mercy listing setup * Updates for Mercy listing * Add city center listing (#260) * Initial City Center listing setup * Updates for City Center listing * Nova Listing v1 * Updated Nova listing * Rename file * json updates * linting issues * Enable sign in (#267) * Bump ssri from 6.0.1 to 6.0.2 (#1194) * feature: support rent as percent income (#1195) * Enable sign in and account creation * Add translations for referral application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> * QA updates for City Center (#268) * Mercy QA updates (#269) * Updates for Mercy listing (#262) * add aurora listing * Enable sign in on application (#273) * Updates for Mercy and City Center (#276) * Update CSV formatter for city_center, mercy and nova * Aurora Listing Updates * Updated translations (#261) * Updated translations * Reduced changes to just override county-specific translations * Updated translation strings * Removed missionCorridor preference translation overrides * Added preference titles Co-authored-by: dominikx96 <dominik@airnauts.com> * Update paper application links for City Center and Mercy (#281) * Update paper application links for City Center and Mercy * Update City Center link * Merge changes 05.11 (#280) * Add description for pulling newest changes from core repository * Updated translations to support listing countyCode * Updated translations * removed extra comma * Removed extra comma * translation file fix * Removed unused properties * Replaced text * Removed extra comma * update nova qa pt 2 * Updated translations * Listings links update (#295) * Update paper application links for City Center and Mercy * Update City Center link * Update paper application links for City Center and Mercy * Update City Center link * Updates for mercy and city center * Display City Center waitlist (#297) * Final qa to city center (#298) * Final City Center QA (#300) * coliseum listing * coliseum json issues * nova updates * aurora qa * update ami chart * updates MetaTags source * updates translation overrides and _app.tsx to add them in for "en" as well * BACKEND_API_BASE is being used from toml instead of netlify env setting * update coliseum pt 3 * coliseum updates pt 5 * coliseum updates pt 6 * coliseum updates pt 7 * coliseum updates pt 8 * removes BACKEND_API_BASE from partners netlify.toml * coliseum 8 * string overrides * coliseum updates pt 9 * coliseum updates pt 10 * coliseum updates pt 11 * coliseum updates pt 12 * Upstream merge (#321) * Removes BACKEND_API_BASE from partners netlify.toml (#1273) * updates pull request template * removes BACKEND_API_BASE from netlify.toml * Add icon support to standard variants of Button component (#1268) * Refactor icon placement in Button component * Update tests and icon placement styles for Button component * Add Icon Button PR to Changelog * Detect proper inline sizing for button * Remove explicit fill color from back arrow icon * fix: preference select text issues (#1270) * feat: new checkbox behavior (#1272) * Bump class-transformer and apply ClassSerializerInterceptor globally (#1265) * Bump class-transformer and apply ClassSerializerInterceptor globally * Switch back to nestjs/swagger@4.6.1 * Regenerate backend-swagger.ts client * Update changelog * Add missing typing to @Transforms * Fix linter * Define generic type for authorizeUserAction * Add a migration fixing extraData serialization problems for applications.preferences Co-authored-by: Bart <bart@barts-macbook-pro.home> * Ensure Netlify builds always do a full rebuild and deploy (#1279) * Fix/preference extradata (#1282) * Save an empty array if there is no extraData * Fixed broken test * Updated changelog * Fix all spec Co-authored-by: dominikx96 <dominik@airnauts.com> * Remove legacy tests sites/public/cypress/integration/pages/applications_new.ts * un-comment out income verification * add back in household validation * add back in live-alone validation * validation typo * comment out validations and the tests w feature flag todo * remove incorrect disclaimer URL check Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> * coliseum updates pt 13 * add office hours update * application links * coliseum updates pt 14 * coliseum updates pt 15 * Mercy QA updates (#315) * Mercy QA updates * Updates for Mercy * Upstream merge (#328) * Add OHA formatter (#1292) * Add OHA formatter * Update changelog * Change coliseum CSVFormattingType to ohaFormat * Fixes for Mercy (#329) * Merge upstream (#330) * Add OHA formatter (#1292) * Add OHA formatter * Update changelog * Remove displaced tenant preferences from ohaFormat CSV formatter (#1293) * Add hopwa preference (#1295) * Add hopwa preference * Update changelog * Update changelog (#1296) * Fixed search param (#1301) * Fixed search param * Updated changelog * Cleanup Co-authored-by: dominikx96 <dominik@airnauts.com> * Bump ws from 7.3.1 to 7.4.6 (#1291) * Replace toPrecision with toFixed (#1304) Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> * mercy updates * mercy updates pt 2 * mercy updates pt 2 * removes production GTM key from netlify config * mercy updates pt 3 * Draft Skyline (#331) Co-authored-by: Ben Kutler <ben@benkutler.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> Co-authored-by: Netra Patil <netrapatil@Netras-MacBook-Pro-2.local> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> Co-authored-by: Netra Badami <58486174+netrabadami@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Bart <bart@barts-macbook-pro.home>

@Transforms

* 1321/listings management, additional details section (bloom-housing#1338) * adds step to db:reseed that adds the uuid extension if it's not present (bloom-housing#1357) Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com> * Add changelog for toPrecision fix (bloom-housing#1310) * 1158/currency field component (bloom-housing#1356) * v1.0.3 * Merge latest master (bloom-housing#1370) * Remove /auth/register endpoint (#140) * late-breaking phone number fix for Jones (#156) * Add monarch listing (#131) * catch up ala site to upstream before Monarch launch (#158) * fix requested QA changes for Monarch (#157) * Fix QA request changes * fix quotes and ordinal on preferences * add listing-specific rentalAssistance text * update office hours for C19 * update rentalAssistance text for Monarch (#159) * apply conditional fix for requiredDocuments from upstream (#163) * Fix deposit for Monarch listing (#161) * Fix deposit for Monarch listing * Update leasing agent address * change monarch pref ordinals to numeric format (#164) * extend Skylyne deadline to 1 Nov per request (#165) * Re-create Re-create SMC Brunswick Listing (#168) * Initial Logan listing (#169) * Update ala feedback link (#170) * Another round of Logan listing QA (#173) * Another round of QA fixes for Logan (#175) * adjust Logan lat/lng for map display (#177) * Update Logan leasing agent number (#179) * fix 2 decimal points for deposit min/max on Logan * Extend skylyne again (#182) * update Skylyne deadline to 12/1 * add triton-test listing from core so automated tests can use it * Fixes for Netlify build * Update from main repo + Alameda * Update SJ subrepo * SMC subrepo update * Update missing changes for Alameda repo * Fix env jsonpaths for templates * Move SMC and SJ listings to backend core * Update application methods for SJ and SMC listings * Move SMC and SJ listings to backend core * Update listings to the new shema * Remove missing route from SJ * Remove additional resources reference from SJ * Hide links to sign in * Add So Hay listing * Update So Hay occupancy * SqFeet fix for So Hay * Add events to So Hay * Update So Hay due date * Fixes for Brunswick listing * 2021 changes for Brunswick * Adds cost not included to Brunswick * Another round of fixes for Brunswick * Update SoHay, add ami chart * So Hay updates with download links * Late January So-Hay update * Copy public-ala over to public * Remove ami_charts * Increase JS heap * Add a mandatory GET listings county query param * Remove housing counselors from next.config.js * Fix HousingCounselors.tsx export * Fix translations * Add housing counselors page * Apply heroku JS VM best practices for container memory size optimization * Increase server request/response timeout * Increase max_old_space_size * Optimize next.js /listings queries * Revert "Add a mandatory GET listings county query param" This reverts commit 9547714. * Add missing jsonpath package * Add Alameda Specific Translation to 0.3 Alameda * Fix PageHeader changes * Fix counselors build * Fix counselors noneFound logic * Fix counselors build * Align Alameda changes with prod * So Hay updates, add events and hide counselors * Update listing_data/so-hay.json * update general.json with text View Additional Housing Opportunities and Resources * removed the second sentence from Nav text * Make hero centered * Remove duplicate get assistance link * Update the Alameda string to not include log-in text * Skip some validations for SoHay listing * Fix So Hay preference format * Improve presentation of the Additional Resources page * Fix class names * Translations for City of Hayward preferences * Update Do You Work In sections * Add link for more mission corridor information * Add the translation to the override file and remove from ui-components * Changed Displaced to Displacee * Final round of updates for So Hay with main repo merge * Update lottery translation * Update lottery translation * Fix lottery translations * Fix SoHay CSVFormattingType in json seed * Switch off the houshold size validation for SoHay * Updated 211 translations * Hotfix CSV encoder * Clean up aside block styling and add missing mobile blocks (bloom-housing#1140) * Clean up aside block styling and add missing mobile blocks * Remove tinting from Open Housts section * Add mercy listing (#259) * Initial Mercy listing setup * Updates for Mercy listing * Add city center listing (#260) * Initial City Center listing setup * Updates for City Center listing * Nova Listing v1 * Updated Nova listing * Rename file * json updates * linting issues * Enable sign in (#267) * Bump ssri from 6.0.1 to 6.0.2 (bloom-housing#1194) * feature: support rent as percent income (bloom-housing#1195) * Enable sign in and account creation * Add translations for referral application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> * QA updates for City Center (#268) * Mercy QA updates (#269) * Updates for Mercy listing (#262) * add aurora listing * Enable sign in on application (#273) * Updates for Mercy and City Center (#276) * Update CSV formatter for city_center, mercy and nova * Aurora Listing Updates * Updated translations (#261) * Updated translations * Reduced changes to just override county-specific translations * Updated translation strings * Removed missionCorridor preference translation overrides * Added preference titles Co-authored-by: dominikx96 <dominik@airnauts.com> * Update paper application links for City Center and Mercy (#281) * Update paper application links for City Center and Mercy * Update City Center link * Merge changes 05.11 (#280) * Add description for pulling newest changes from core repository * Updated translations to support listing countyCode * Updated translations * removed extra comma * Removed extra comma * translation file fix * Removed unused properties * Replaced text * Removed extra comma * update nova qa pt 2 * Updated translations * Listings links update (#295) * Update paper application links for City Center and Mercy * Update City Center link * Update paper application links for City Center and Mercy * Update City Center link * Updates for mercy and city center * Display City Center waitlist (#297) * Final qa to city center (#298) * Final City Center QA (#300) * coliseum listing * coliseum json issues * nova updates * aurora qa * update ami chart * updates MetaTags source * updates translation overrides and _app.tsx to add them in for "en" as well * BACKEND_API_BASE is being used from toml instead of netlify env setting * update coliseum pt 3 * coliseum updates pt 5 * coliseum updates pt 6 * coliseum updates pt 7 * coliseum updates pt 8 * removes BACKEND_API_BASE from partners netlify.toml * coliseum 8 * string overrides * coliseum updates pt 9 * coliseum updates pt 10 * coliseum updates pt 11 * coliseum updates pt 12 * Upstream merge (#321) * Removes BACKEND_API_BASE from partners netlify.toml (bloom-housing#1273) * updates pull request template * removes BACKEND_API_BASE from netlify.toml * Add icon support to standard variants of Button component (bloom-housing#1268) * Refactor icon placement in Button component * Update tests and icon placement styles for Button component * Add Icon Button PR to Changelog * Detect proper inline sizing for button * Remove explicit fill color from back arrow icon * fix: preference select text issues (bloom-housing#1270) * feat: new checkbox behavior (bloom-housing#1272) * Bump class-transformer and apply ClassSerializerInterceptor globally (bloom-housing#1265) * Bump class-transformer and apply ClassSerializerInterceptor globally * Switch back to nestjs/swagger@4.6.1 * Regenerate backend-swagger.ts client * Update changelog * Add missing typing to @Transforms * Fix linter * Define generic type for authorizeUserAction * Add a migration fixing extraData serialization problems for applications.preferences Co-authored-by: Bart <bart@barts-macbook-pro.home> * Ensure Netlify builds always do a full rebuild and deploy (bloom-housing#1279) * Fix/preference extradata (bloom-housing#1282) * Save an empty array if there is no extraData * Fixed broken test * Updated changelog * Fix all spec Co-authored-by: dominikx96 <dominik@airnauts.com> * Remove legacy tests sites/public/cypress/integration/pages/applications_new.ts * un-comment out income verification * add back in household validation * add back in live-alone validation * validation typo * comment out validations and the tests w feature flag todo * remove incorrect disclaimer URL check Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> * coliseum updates pt 13 * add office hours update * application links * coliseum updates pt 14 * coliseum updates pt 15 * Mercy QA updates (#315) * Mercy QA updates * Updates for Mercy * Upstream merge (#328) * Add OHA formatter (bloom-housing#1292) * Add OHA formatter * Update changelog * Change coliseum CSVFormattingType to ohaFormat * Fixes for Mercy (#329) * Merge upstream (#330) * Add OHA formatter (bloom-housing#1292) * Add OHA formatter * Update changelog * Remove displaced tenant preferences from ohaFormat CSV formatter (bloom-housing#1293) * Add hopwa preference (bloom-housing#1295) * Add hopwa preference * Update changelog * Update changelog (bloom-housing#1296) * Fixed search param (bloom-housing#1301) * Fixed search param * Updated changelog * Cleanup Co-authored-by: dominikx96 <dominik@airnauts.com> * Bump ws from 7.3.1 to 7.4.6 (bloom-housing#1291) * Replace toPrecision with toFixed (bloom-housing#1304) Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> * mercy updates * mercy updates pt 2 * mercy updates pt 2 * removes production GTM key from netlify config * mercy updates pt 3 * Draft Skyline (#331) Co-authored-by: Ben Kutler <ben@benkutler.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> Co-authored-by: Netra Patil <netrapatil@Netras-MacBook-Pro-2.local> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> Co-authored-by: Netra Badami <58486174+netrabadami@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> * Issue 1362/total flagged bug (bloom-housing#1366) * Fix counting totalFlagged property in AFS module * Fix a race condition in AFS module * Update changelog * fix retry import * Throw 429 on application creation retry failure Co-authored-by: Sean Albert <smabert@gmail.com> * fix merge conflicts in master (bloom-housing#1375) * Replace UserContext with AuthContext (bloom-housing#1311) * Replace UserContext with AuthContext * Remove api_requests * Fix imports * Fix userService params * Fix ConfirmationModal * Add missing appUrl * Fixes after rebase and remove useRouter for ui-components * Fix language passed to axios * Adds debug instructions to backend/core readme (#15) (bloom-housing#1390) * Adds start command for backend in debug mode (#15) * Adds start command for backend in debug mode * add notes to readme on debugging the backend * remove package.json changes since there was already a debug command, and update readme (#16) * Add backend/proxy Dockerfile, README.md and nginx config file (bloom-housing#1380) * Add backend/proxy Dockerfile, README.md and nginx config file * Update changelog * Add /jurisdictions endpoint (bloom-housing#1391) * Add /jurisdictions endpoint * Update changelog * Update migration to create jurisdiction relation automatically for existing listings * Revert "Merge latest master (bloom-housing#1370)" (bloom-housing#1394) * Revert "Merge latest master (bloom-housing#1370)" This reverts commit 845f2e6. * Retain overrideTranslations related change from housingbayarea fork Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com> Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> Co-authored-by: Ben Kutler <ben@benkutler.com> Co-authored-by: Netra Patil <netrapatil@Netras-MacBook-Pro-2.local> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> Co-authored-by: Netra Badami <58486174+netrabadami@users.noreply.github.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Bart <bart@barts-macbook-pro.home>

@Transforms

* Re-create Re-create SMC Brunswick Listing (#168) * Initial Logan listing (#169) * Update ala feedback link (#170) * Another round of Logan listing QA (#173) * Another round of QA fixes for Logan (#175) * adjust Logan lat/lng for map display (#177) * Update Logan leasing agent number (#179) * fix 2 decimal points for deposit min/max on Logan * Extend skylyne again (#182) * update Skylyne deadline to 12/1 * add triton-test listing from core so automated tests can use it * Fixes for Netlify build * Update from main repo + Alameda * Update SJ subrepo * SMC subrepo update * Update missing changes for Alameda repo * Fix env jsonpaths for templates * Move SMC and SJ listings to backend core * Update application methods for SJ and SMC listings * Move SMC and SJ listings to backend core * Update listings to the new shema * Remove missing route from SJ * Remove additional resources reference from SJ * Hide links to sign in * Add So Hay listing * Update So Hay occupancy * SqFeet fix for So Hay * Add events to So Hay * Update So Hay due date * Fixes for Brunswick listing * 2021 changes for Brunswick * Adds cost not included to Brunswick * Another round of fixes for Brunswick * Update SoHay, add ami chart * So Hay updates with download links * Late January So-Hay update * Copy public-ala over to public * Remove ami_charts * Increase JS heap * Add a mandatory GET listings county query param * Remove housing counselors from next.config.js * Fix HousingCounselors.tsx export * Fix translations * Add housing counselors page * Apply heroku JS VM best practices for container memory size optimization * Increase server request/response timeout * Increase max_old_space_size * Optimize next.js /listings queries * Revert "Add a mandatory GET listings county query param" This reverts commit 9547714. * Add missing jsonpath package * Add Alameda Specific Translation to 0.3 Alameda * Fix PageHeader changes * Fix counselors build * Fix counselors noneFound logic * Fix counselors build * Align Alameda changes with prod * So Hay updates, add events and hide counselors * Update listing_data/so-hay.json * update general.json with text View Additional Housing Opportunities and Resources * removed the second sentence from Nav text * Make hero centered * Remove duplicate get assistance link * Update the Alameda string to not include log-in text * Skip some validations for SoHay listing * Fix So Hay preference format * Improve presentation of the Additional Resources page * Fix class names * Translations for City of Hayward preferences * Update Do You Work In sections * Add link for more mission corridor information * Add the translation to the override file and remove from ui-components * Changed Displaced to Displacee * Final round of updates for So Hay with main repo merge * Update lottery translation * Update lottery translation * Fix lottery translations * Fix SoHay CSVFormattingType in json seed * Switch off the houshold size validation for SoHay * Updated 211 translations * Hotfix CSV encoder * Clean up aside block styling and add missing mobile blocks (#1140) * Clean up aside block styling and add missing mobile blocks * Remove tinting from Open Housts section * Add mercy listing (#259) * Initial Mercy listing setup * Updates for Mercy listing * Add city center listing (#260) * Initial City Center listing setup * Updates for City Center listing * Nova Listing v1 * Updated Nova listing * Rename file * json updates * linting issues * Enable sign in (#267) * Bump ssri from 6.0.1 to 6.0.2 (#1194) * feature: support rent as percent income (#1195) * Enable sign in and account creation * Add translations for referral application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> * QA updates for City Center (#268) * Mercy QA updates (#269) * Updates for Mercy listing (#262) * add aurora listing * Enable sign in on application (#273) * Updates for Mercy and City Center (#276) * Update CSV formatter for city_center, mercy and nova * Aurora Listing Updates * Updated translations (#261) * Updated translations * Reduced changes to just override county-specific translations * Updated translation strings * Removed missionCorridor preference translation overrides * Added preference titles Co-authored-by: dominikx96 <dominik@airnauts.com> * Update paper application links for City Center and Mercy (#281) * Update paper application links for City Center and Mercy * Update City Center link * Merge changes 05.11 (#280) * Add description for pulling newest changes from core repository * Updated translations to support listing countyCode * Updated translations * removed extra comma * Removed extra comma * translation file fix * Removed unused properties * Replaced text * Removed extra comma * update nova qa pt 2 * Updated translations * Listings links update (#295) * Update paper application links for City Center and Mercy * Update City Center link * Update paper application links for City Center and Mercy * Update City Center link * Updates for mercy and city center * Display City Center waitlist (#297) * Final qa to city center (#298) * Final City Center QA (#300) * coliseum listing * coliseum json issues * nova updates * aurora qa * update ami chart * updates MetaTags source * updates translation overrides and _app.tsx to add them in for "en" as well * BACKEND_API_BASE is being used from toml instead of netlify env setting * update coliseum pt 3 * coliseum updates pt 5 * coliseum updates pt 6 * coliseum updates pt 7 * coliseum updates pt 8 * removes BACKEND_API_BASE from partners netlify.toml * coliseum 8 * string overrides * coliseum updates pt 9 * coliseum updates pt 10 * coliseum updates pt 11 * coliseum updates pt 12 * Upstream merge (#321) * Removes BACKEND_API_BASE from partners netlify.toml (#1273) * updates pull request template * removes BACKEND_API_BASE from netlify.toml * Add icon support to standard variants of Button component (#1268) * Refactor icon placement in Button component * Update tests and icon placement styles for Button component * Add Icon Button PR to Changelog * Detect proper inline sizing for button * Remove explicit fill color from back arrow icon * fix: preference select text issues (#1270) * feat: new checkbox behavior (#1272) * Bump class-transformer and apply ClassSerializerInterceptor globally (#1265) * Bump class-transformer and apply ClassSerializerInterceptor globally * Switch back to nestjs/swagger@4.6.1 * Regenerate backend-swagger.ts client * Update changelog * Add missing typing to @Transforms * Fix linter * Define generic type for authorizeUserAction * Add a migration fixing extraData serialization problems for applications.preferences Co-authored-by: Bart <bart@barts-macbook-pro.home> * Ensure Netlify builds always do a full rebuild and deploy (#1279) * Fix/preference extradata (#1282) * Save an empty array if there is no extraData * Fixed broken test * Updated changelog * Fix all spec Co-authored-by: dominikx96 <dominik@airnauts.com> * Remove legacy tests sites/public/cypress/integration/pages/applications_new.ts * un-comment out income verification * add back in household validation * add back in live-alone validation * validation typo * comment out validations and the tests w feature flag todo * remove incorrect disclaimer URL check Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> * coliseum updates pt 13 * add office hours update * application links * coliseum updates pt 14 * coliseum updates pt 15 * Mercy QA updates (#315) * Mercy QA updates * Updates for Mercy * Upstream merge (#328) * Add OHA formatter (#1292) * Add OHA formatter * Update changelog * Change coliseum CSVFormattingType to ohaFormat * Fixes for Mercy (#329) * Merge upstream (#330) * Add OHA formatter (#1292) * Add OHA formatter * Update changelog * Remove displaced tenant preferences from ohaFormat CSV formatter (#1293) * Add hopwa preference (#1295) * Add hopwa preference * Update changelog * Update changelog (#1296) * Fixed search param (#1301) * Fixed search param * Updated changelog * Cleanup Co-authored-by: dominikx96 <dominik@airnauts.com> * Bump ws from 7.3.1 to 7.4.6 (#1291) * Replace toPrecision with toFixed (#1304) Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> * mercy updates * mercy updates pt 2 * mercy updates pt 2 * removes production GTM key from netlify config * mercy updates pt 3 * Draft Skyline (#331) * mercy updates pt 4 * text updates * Initial add of Alexan (#341) * Initial add of Alexan * Next round of Alexan changes * Fix Alexan link * Skyline QA updates (#343) * Merge upstream/06.23 (#346) * 1321/listings management, additional details section (#1338) * adds step to db:reseed that adds the uuid extension if it's not present (#1357) Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com> * Add changelog for toPrecision fix (#1310) * 1158/currency field component (#1356) * v1.0.3 * Merge latest master (#1370) * Remove /auth/register endpoint (#140) * late-breaking phone number fix for Jones (#156) * Add monarch listing (#131) * catch up ala site to upstream before Monarch launch (#158) * fix requested QA changes for Monarch (#157) * Fix QA request changes * fix quotes and ordinal on preferences * add listing-specific rentalAssistance text * update office hours for C19 * update rentalAssistance text for Monarch (#159) * apply conditional fix for requiredDocuments from upstream (#163) * Fix deposit for Monarch listing (#161) * Fix deposit for Monarch listing * Update leasing agent address * change monarch pref ordinals to numeric format (#164) * extend Skylyne deadline to 1 Nov per request (#165) * Re-create Re-create SMC Brunswick Listing (#168) * Initial Logan listing (#169) * Update ala feedback link (#170) * Another round of Logan listing QA (#173) * Another round of QA fixes for Logan (#175) * adjust Logan lat/lng for map display (#177) * Update Logan leasing agent number (#179) * fix 2 decimal points for deposit min/max on Logan * Extend skylyne again (#182) * update Skylyne deadline to 12/1 * add triton-test listing from core so automated tests can use it * Fixes for Netlify build * Update from main repo + Alameda * Update SJ subrepo * SMC subrepo update * Update missing changes for Alameda repo * Fix env jsonpaths for templates * Move SMC and SJ listings to backend core * Update application methods for SJ and SMC listings * Move SMC and SJ listings to backend core * Update listings to the new shema * Remove missing route from SJ * Remove additional resources reference from SJ * Hide links to sign in * Add So Hay listing * Update So Hay occupancy * SqFeet fix for So Hay * Add events to So Hay * Update So Hay due date * Fixes for Brunswick listing * 2021 changes for Brunswick * Adds cost not included to Brunswick * Another round of fixes for Brunswick * Update SoHay, add ami chart * So Hay updates with download links * Late January So-Hay update * Copy public-ala over to public * Remove ami_charts * Increase JS heap * Add a mandatory GET listings county query param * Remove housing counselors from next.config.js * Fix HousingCounselors.tsx export * Fix translations * Add housing counselors page * Apply heroku JS VM best practices for container memory size optimization * Increase server request/response timeout * Increase max_old_space_size * Optimize next.js /listings queries * Revert "Add a mandatory GET listings county query param" This reverts commit 9547714. * Add missing jsonpath package * Add Alameda Specific Translation to 0.3 Alameda * Fix PageHeader changes * Fix counselors build * Fix counselors noneFound logic * Fix counselors build * Align Alameda changes with prod * So Hay updates, add events and hide counselors * Update listing_data/so-hay.json * update general.json with text View Additional Housing Opportunities and Resources * removed the second sentence from Nav text * Make hero centered * Remove duplicate get assistance link * Update the Alameda string to not include log-in text * Skip some validations for SoHay listing * Fix So Hay preference format * Improve presentation of the Additional Resources page * Fix class names * Translations for City of Hayward preferences * Update Do You Work In sections * Add link for more mission corridor information * Add the translation to the override file and remove from ui-components * Changed Displaced to Displacee * Final round of updates for So Hay with main repo merge * Update lottery translation * Update lottery translation * Fix lottery translations * Fix SoHay CSVFormattingType in json seed * Switch off the houshold size validation for SoHay * Updated 211 translations * Hotfix CSV encoder * Clean up aside block styling and add missing mobile blocks (#1140) * Clean up aside block styling and add missing mobile blocks * Remove tinting from Open Housts section * Add mercy listing (#259) * Initial Mercy listing setup * Updates for Mercy listing * Add city center listing (#260) * Initial City Center listing setup * Updates for City Center listing * Nova Listing v1 * Updated Nova listing * Rename file * json updates * linting issues * Enable sign in (#267) * Bump ssri from 6.0.1 to 6.0.2 (#1194) * feature: support rent as percent income (#1195) * Enable sign in and account creation * Add translations for referral application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> * QA updates for City Center (#268) * Mercy QA updates (#269) * Updates for Mercy listing (#262) * add aurora listing * Enable sign in on application (#273) * Updates for Mercy and City Center (#276) * Update CSV formatter for city_center, mercy and nova * Aurora Listing Updates * Updated translations (#261) * Updated translations * Reduced changes to just override county-specific translations * Updated translation strings * Removed missionCorridor preference translation overrides * Added preference titles Co-authored-by: dominikx96 <dominik@airnauts.com> * Update paper application links for City Center and Mercy (#281) * Update paper application links for City Center and Mercy * Update City Center link * Merge changes 05.11 (#280) * Add description for pulling newest changes from core repository * Updated translations to support listing countyCode * Updated translations * removed extra comma * Removed extra comma * translation file fix * Removed unused properties * Replaced text * Removed extra comma * update nova qa pt 2 * Updated translations * Listings links update (#295) * Update paper application links for City Center and Mercy * Update City Center link * Update paper application links for City Center and Mercy * Update City Center link * Updates for mercy and city center * Display City Center waitlist (#297) * Final qa to city center (#298) * Final City Center QA (#300) * coliseum listing * coliseum json issues * nova updates * aurora qa * update ami chart * updates MetaTags source * updates translation overrides and _app.tsx to add them in for "en" as well * BACKEND_API_BASE is being used from toml instead of netlify env setting * update coliseum pt 3 * coliseum updates pt 5 * coliseum updates pt 6 * coliseum updates pt 7 * coliseum updates pt 8 * removes BACKEND_API_BASE from partners netlify.toml * coliseum 8 * string overrides * coliseum updates pt 9 * coliseum updates pt 10 * coliseum updates pt 11 * coliseum updates pt 12 * Upstream merge (#321) * Removes BACKEND_API_BASE from partners netlify.toml (#1273) * updates pull request template * removes BACKEND_API_BASE from netlify.toml * Add icon support to standard variants of Button component (#1268) * Refactor icon placement in Button component * Update tests and icon placement styles for Button component * Add Icon Button PR to Changelog * Detect proper inline sizing for button * Remove explicit fill color from back arrow icon * fix: preference select text issues (#1270) * feat: new checkbox behavior (#1272) * Bump class-transformer and apply ClassSerializerInterceptor globally (#1265) * Bump class-transformer and apply ClassSerializerInterceptor globally * Switch back to nestjs/swagger@4.6.1 * Regenerate backend-swagger.ts client * Update changelog * Add missing typing to @Transforms * Fix linter * Define generic type for authorizeUserAction * Add a migration fixing extraData serialization problems for applications.preferences Co-authored-by: Bart <bart@barts-macbook-pro.home> * Ensure Netlify builds always do a full rebuild and deploy (#1279) * Fix/preference extradata (#1282) * Save an empty array if there is no extraData * Fixed broken test * Updated changelog * Fix all spec Co-authored-by: dominikx96 <dominik@airnauts.com> * Remove legacy tests sites/public/cypress/integration/pages/applications_new.ts * un-comment out income verification * add back in household validation * add back in live-alone validation * validation typo * comment out validations and the tests w feature flag todo * remove incorrect disclaimer URL check Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> * coliseum updates pt 13 * add office hours update * application links * coliseum updates pt 14 * coliseum updates pt 15 * Mercy QA updates (#315) * Mercy QA updates * Updates for Mercy * Upstream merge (#328) * Add OHA formatter (#1292) * Add OHA formatter * Update changelog * Change coliseum CSVFormattingType to ohaFormat * Fixes for Mercy (#329) * Merge upstream (#330) * Add OHA formatter (#1292) * Add OHA formatter * Update changelog * Remove displaced tenant preferences from ohaFormat CSV formatter (#1293) * Add hopwa preference (#1295) * Add hopwa preference * Update changelog * Update changelog (#1296) * Fixed search param (#1301) * Fixed search param * Updated changelog * Cleanup Co-authored-by: dominikx96 <dominik@airnauts.com> * Bump ws from 7.3.1 to 7.4.6 (#1291) * Replace toPrecision with toFixed (#1304) Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> * mercy updates * mercy updates pt 2 * mercy updates pt 2 * removes production GTM key from netlify config * mercy updates pt 3 * Draft Skyline (#331) Co-authored-by: Ben Kutler <ben@benkutler.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> Co-authored-by: Netra Patil <netrapatil@Netras-MacBook-Pro-2.local> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> Co-authored-by: Netra Badami <58486174+netrabadami@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> * Issue 1362/total flagged bug (#1366) * Fix counting totalFlagged property in AFS module * Fix a race condition in AFS module * Update changelog * fix retry import * Throw 429 on application creation retry failure Co-authored-by: Sean Albert <smabert@gmail.com> * fix merge conflicts in master (#1375) * Replace UserContext with AuthContext (#1311) * Replace UserContext with AuthContext * Remove api_requests * Fix imports * Fix userService params * Fix ConfirmationModal * Add missing appUrl * Fixes after rebase and remove useRouter for ui-components * Fix language passed to axios * Adds debug instructions to backend/core readme (#15) (#1390) * Adds start command for backend in debug mode (#15) * Adds start command for backend in debug mode * add notes to readme on debugging the backend * remove package.json changes since there was already a debug command, and update readme (#16) * Add backend/proxy Dockerfile, README.md and nginx config file (#1380) * Add backend/proxy Dockerfile, README.md and nginx config file * Update changelog * Add /jurisdictions endpoint (#1391) * Add /jurisdictions endpoint * Update changelog * Update migration to create jurisdiction relation automatically for existing listings * Revert "Merge latest master (#1370)" (#1394) * Revert "Merge latest master (#1370)" This reverts commit 845f2e6. * Retain overrideTranslations related change from housingbayarea fork Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com> Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com> Co-authored-by: Marcin Jędras <mjjedras@gmail.com> Co-authored-by: Ben Kutler <ben@benkutler.com> Co-authored-by: Netra Patil <netrapatil@Netras-MacBook-Pro-2.local> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> Co-authored-by: Netra Badami <58486174+netrabadami@users.noreply.github.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> * Initial add Jordan listing (#342) * Initial add Jordan listing * Add leasing agent for Jordan * Add preferences for Alexan (#347) * Add preferences for Alexan * Alexan QA and preferences update * Add unavailable units for Skyline (#344) * linter cleanup * comment add member tests as before * comment out live-alone test as before Co-authored-by: Marcin Jędras <mjjedras@gmail.com> Co-authored-by: Ben Kutler <ben@benkutler.com> Co-authored-by: Michal Plebanski <michalp@airnauts.com> Co-authored-by: Netra Patil <netrapatil@Netras-MacBook-Pro-2.local> Co-authored-by: Jared White <jared@jaredwhite.com> Co-authored-by: Michał Plebański <m.plebanski4@gmail.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> Co-authored-by: Netra Badami <58486174+netrabadami@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: dominikx96 <dominik@airnauts.com> Co-authored-by: dominikx96 <dominikx96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bart <bart@barts-macbook-pro.home> Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com> Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>

emilyjablonski added the wip This PR is not ready for review, do not review it's a “Work In Progress” label May 26, 2021

emilyjablonski requested review from jaredcwhite, seanmalbert and dominikx96 May 26, 2021 20:44

emilyjablonski linked an issue May 26, 2021 that may be closed by this pull request

Flag for none of these preferences apply to me #1229

Closed

emilyjablonski added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels May 26, 2021

emilyjablonski marked this pull request as ready for review May 26, 2021 20:48

jaredcwhite reviewed May 26, 2021

View reviewed changes

sites/partners/src/applications/PaperApplicationForm/sections/FormPreferences.tsx Outdated Show resolved Hide resolved

seanmalbert reviewed May 27, 2021

View reviewed changes

emilyjablonski added 6 commits May 27, 2021 18:27

feat: new checkbox behavior

9ea7c1b

feat: new checkbox behavior 2

bd977fd

add the functionality to partners

ab6b88f

pr feedback

50ff28f

remove setTimeout

8dd4597

resolve exclusive not appearing

ad26827

emilyjablonski force-pushed the feat/new-checkbox-behavior branch from 563e40b to ad26827 Compare May 28, 2021 00:36

emilyjablonski added 2 commits May 27, 2021 18:42

rebase issues

874fd4c

remove coliseum

6710877

seanmalbert approved these changes May 28, 2021

View reviewed changes

emilyjablonski merged commit baa0c24 into master May 28, 2021

emilyjablonski deleted the feat/new-checkbox-behavior branch May 28, 2021 01:00

willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021

feat: new checkbox behavior (#1272)

1a1fab0

willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021

Revert "feat: new checkbox behavior (#1272)"

2e585cc

This reverts commit 1a1fab0.

willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021

Revert "feat: new checkbox behavior (#1272)"

a82bb4e

This reverts commit 1a1fab0.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new checkbox behavior #1272

feat: new checkbox behavior #1272

emilyjablonski commented May 26, 2021 •

edited

Loading

netlify bot commented May 26, 2021 •

edited

Loading

jaredcwhite left a comment

emilyjablonski commented May 26, 2021

jaredcwhite commented May 27, 2021

seanmalbert left a comment

seanmalbert May 27, 2021

emilyjablonski May 27, 2021

seanmalbert May 27, 2021

emilyjablonski May 27, 2021

seanmalbert left a comment

feat: new checkbox behavior #1272

feat: new checkbox behavior #1272

Conversation

emilyjablonski commented May 26, 2021 • edited Loading

Pull Request Template

Issue

Description

Type of change

How Can This Be Tested/Reviewed?

Checklist:

netlify bot commented May 26, 2021 • edited Loading

jaredcwhite left a comment

Choose a reason for hiding this comment

emilyjablonski commented May 26, 2021

jaredcwhite commented May 27, 2021

seanmalbert left a comment

Choose a reason for hiding this comment

seanmalbert May 27, 2021

Choose a reason for hiding this comment

emilyjablonski May 27, 2021

Choose a reason for hiding this comment

seanmalbert May 27, 2021

Choose a reason for hiding this comment

emilyjablonski May 27, 2021

Choose a reason for hiding this comment

seanmalbert left a comment

Choose a reason for hiding this comment

emilyjablonski commented May 26, 2021 •

edited

Loading

netlify bot commented May 26, 2021 •

edited

Loading