1574/remove business logic from from ListingsList component

[emilyjablonski]

Pull Request Template

Issue

Addresses #1574

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

A request from SF to remove business logic from the ListingsList component by creating a new ListingCard component that takes in the image props and the table props.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Prototype/POC (not to merge)
• This change is a refactor/address technical debt
• This change requires a documentation update
• This change requires a SQL Script

How Can This Be Tested/Reviewed?

Ensure the /listings page renders as expected

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have updated the changelog to include a description of my changes

[netlify]

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 2e1947d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/612966806d1a2f0008030ee7

😎 Browse the preview: https://deploy-preview-1773--dev-bloom.netlify.app

[netlify]

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 78d22d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/612965a260cff6000750df2c

😎 Browse the preview: https://deploy-preview-1773--clever-edison-cd22c1.netlify.app

[netlify]

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 2e1947d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/612966805203a50007c2a751

😎 Browse the preview: https://deploy-preview-1773--dev-partners-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 2e1947d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6129668052fc0200081af847

😎 Browse the preview: https://deploy-preview-1773--dev-storybook-bloom.netlify.app

[netlify]

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 2e1947d

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/61296680e0b51400084e74ac

😎 Browse the preview: https://deploy-preview-1773--clever-edison-cd22c1.netlify.app

[seanmalbert]

Looks good to me. The new functions, getListingImageCardStatus, getListingCardSubtitle and getListingTableData, look like good candidates for unit tests. If there's urgency to get this in, then can you please create an issue to write tests for these and add it to the backlog.

[emilyjablonski]

As it's blocking DAHLIA I'll merge and write the tests today 👍