All Bloomberg Changes for Private Fields and Methods #6

mheiber · 2018-08-23T21:48:49Z

Now on the TypeScript Repo!: microsoft#30829

This is the best place to view all of Bloomberg's work on the TypeScript compiler for supporting class private fields and private methods.

This pull request shows all of our work that has been reviewed. This includes the following changes:

Parse Private Names #4: adding private names support to the parser

We have other work in progress here: https://github.com/bloomberg/TypeScript/pulls, including:

Private Name Support in the Checker #5: adding private names support to the checker
(WIP) Private name class field transformation #8: class private fields

…oft#27338)

Infer array rest as tuple if possible

Refactoring to unify updating no input files error

Default logger for projectService has assert on exceptions being logged in tsserver

Don't complain about `modules` and `outFile` options when `emitDeclarationOnly` is set.

Remove unneeded `argName` check, because it always evaluates to `true` (the `false` case is handled just before the modified line)

Update spec.md to fix minor typo

Small refactoring of getTransformationBody

* Fix GH#18217 issue for FileLog. * Refactor FileLog class to not use isEnabled property.

…r visibility (microsoft#27444)

…-exception-27338 Use safe some function to handle undefined declarations (fixes microsoft#27338)

…extends-helper adding missing semi-colon to extendsHelper

closes microsoft#25976

chore(package.json): http -> https, add www. for homepage

TypeScript must hoist accessors for super properties when converting async method bodies to the `__awaiter` pattern for targets before ES2016. Previously, TypeScript would reify all property accesses into element accesses, i.e. convert the property name into a string parameter and pass it to `super[...]`. That breaks optimizers like Closure Compiler or Uglify in advanced mode, when property renaming is enabled, as it mixes quoted and un-quoted property access (`super['x']` vs just `x` at the declaration site). This change creates a variable `_superProps` that contains accessors for each property accessed on super within the async method. This allows accessing the properties by name (instead of quoted string), which fixes the quoted/unquoted confusion. The change keeps the generic accessor for element access statements to match quoting behaviour. Fixes microsoft#21088.

* rename _super to _superIndex and _superProps to _super. * reinstate early exit for transformers by marking super accesses as esnext/es2017 in `binder.ts`. * adjust comment in `checker.ts` to new emit.

- Narrow unknown - Narrow union members (in addition to filtering)

…or ':' (microsoft#28121)

…microsoft#28141) * JSX uses mixed signatures and union sigs use subtype on partial match * Small improvement

…eConstraint No constraint for { [P in K]: XXX } where K is type variable

…icrosoft#27804) * Measure variance of aliased conditional types using variance markers * Just do variance probing for all type aliases * Small limiter for predictability * Inline property set, remove unused functions

…ToValue (microsoft#28171)

…8137)

…t#28207)

…g when invoked. (microsoft#28206) * Do not ts-ignore noImplicitAny suggestions Still need to write tests. * Add tests * More tests * Update baselines

and check that private names not used in parameters Signed-off-by: Max Heiber <max.heiber@gmail.com> Signed-off-by: Max Heiber <mheiber@bloomberg.net>

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

* Add baselines * Update baselines Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Moves the transformation of class properties to the ESNext transformer. Property initializers are moved to the constructor by the TypeScript transformer only if there is constructor parameter properties. This is to preserve property initialization order. It currently does not produce void 0 initializers for property declarations that have no initializer due to ESNext and TypeScript having different runtime behaviors. TS completely elides property declarations with no initializer, while I believe the ESNext would define that property on the instance with an undefined value (which is observable at runtime - propertyName in instance or for (var prop in instance) {}).

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Fix display of private names in the TS Language Server

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Transform private named instance fields

* wip: add types * wip * Add cases * Add some case * Add more check * accept baseline * add abstract abd declare method * add override in declaration * accept baseline * add property override * Fix decalre modifier * update baseline * Add more cases * make lint happy * make lint happy * Update description * Add codefix * simplify code * accept baseline * Update desc * Accept baseline * Add override completions * filter out implements field in override context * fix tests * Add parameter property check * Accept baseline * acept baseline * Add parameter property to declaration code action * Add quickfix for override parameter property * fix code style * Add override with interface tests * Add more cases about modifier position * rename flag * rename flags * Added tests. * Accepted baselines. * Always issue errors for unnecessary 'override' modifiers. * Accepted baselines. * Override perf (#4) * try cache check result * pre check for override * Do not issue error if implement abstract * Add abstract-spec check * Avoid override dead lock * Add more case * Add codefix for new error * Fix error message * Add jsdoc override tag (#6) * Override jsdoc tag (#7) * accept baseline * Disallow codefix in js * update baseline * Omit override in d.ts * Add more case in js * Accept baseline * fix override js test * fix crlf * Revert merge conflict changes * Accept baseline * Avoid space * Fix CR issues * Accept baseline * Fix typo and add more check * Fix error name Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>

mheiber changed the title ~~Es private fields~~ [WIP] All Bloomberg Changes Aug 23, 2018

mheiber mentioned this pull request Aug 27, 2018

Implement private fields proposal microsoft/TypeScript#9950

Closed

mheiber changed the title ~~[WIP] All Bloomberg Changes~~ All Bloomberg Changes Sep 25, 2018

mheiber changed the title ~~All Bloomberg Changes~~ All Bloomberg Changes for Private Fields and Methods Sep 25, 2018

IllusionMH and others added 26 commits October 1, 2018 23:11

Use safe some function to handle undefined declarations (fixes micros…

d0abd39

…oft#27338)

Merge pull request microsoft#26070 from ajafff/tuple-rest

3331d07

Infer array rest as tuple if possible

Merge pull request microsoft#27395 from Microsoft/noFilesError

6e8027e

Refactoring to unify updating no input files error

Merge pull request microsoft#27443 from Microsoft/errorMessageLogger

29dd67e

Default logger for projectService has assert on exceptions being logged in tsserver

Merge pull request microsoft#27447 from mattmccutchen/issue-27117

70e26fc

Don't complain about `modules` and `outFile` options when `emitDeclarationOnly` is set.

No unsound assignments to T[K] when T and K are both generic

c0c215f

Accept new baselines

2801c97

Add tests

3499462

Accept new baselines

69cd6c0

Insert async keyword as last modifier (microsoft#27491)

f356cd6

Update spec.md

12686e7

Remove unneeded check from getTransformationBody

bbf7753

Remove unneeded `argName` check, because it always evaluates to `true` (the `false` case is handled just before the modified line)

Merge pull request microsoft#27499 from surlymrz/surlymrz-patch-1

76ab912

Update spec.md to fix minor typo

Merge pull request microsoft#27500 from Loghorn/patch-1

0d92bd5

Small refactoring of getTransformationBody

Update user baselines (microsoft#27498)

1237df7

Fix GH#18217 issue for FileLog. (microsoft#27430)

b15d6a4

* Fix GH#18217 issue for FileLog. * Refactor FileLog class to not use isEnabled property.

Exclude the overlap between Type and Value when checking for paramete…

1e55d65

…r visibility (microsoft#27444)

Merge pull request microsoft#27485 from IllusionMH/fix-completionInfo…

c04faa1

…-exception-27338 Use safe some function to handle undefined declarations (fixes microsoft#27338)

Merge pull request microsoft#27313 from spratmannc/spratmannc/fixing-…

5f96fb1

…extends-helper adding missing semi-colon to extendsHelper

textChanges: Reuse some methods (microsoft#27492)

16766b1

📝 Better description of Pick mapped type

c86b9ca

closes microsoft#25976

fix typo in performance mark name

804a2fd

Merge pull request microsoft#27360 from limonte/patch-1

ef4ae3f

chore(package.json): http -> https, add www. for homepage

Also --init git submodules when running user tests (microsoft#27508)

9aeb6e2

Fixes for review comments.

e618d75

* rename _super to _superIndex and _superProps to _super. * reinstate early exit for transformers by marking super accesses as esnext/es2017 in `binder.ts`. * adjust comment in `checker.ts` to new emit.

Andy and others added 15 commits October 26, 2018 14:44

Remove unused property ParameterInference#typeNode (microsoft#28115)

77d8e15

Bring typeof switch inline with if (microsoft#27680)

abce9ae

- Narrow unknown - Narrow union members (in addition to filtering)

Parse an object literal property as shorthand unless followed by '(' …

36dfd77

…or ':' (microsoft#28121)

Add regression test

24e3745

Accept new baselines

00fbded

JSX uses mixed signatures and union sigs use subtype on partial match (…

972c403

…microsoft#28141) * JSX uses mixed signatures and union sigs use subtype on partial match * Small improvement

Merge pull request microsoft#28170 from Microsoft/fixGenericMappedTyp…

ccc1613

…eConstraint No constraint for { [P in K]: XXX } where K is type variable

Use same condition in isReferencedAliasDeclaration as isAliasResolved…

a695288

…ToValue (microsoft#28171)

Always use verify.completions when testing completions (microsoft#2…

c97fc64

…8137)

Have flatMap return a ReadonlyArray by default (microsoft#28205)

672b0e3

Allow to combine --resolveJsonModule with --isolatedModules (microsof…

24febc2

…t#28207)

infer-from-usage suggestions can't be ignored, and always do somethin…

60efb65

…g when invoked. (microsoft#28206) * Do not ts-ignore noImplicitAny suggestions Still need to write tests. * Add tests * More tests * Update baselines

Update Travis-CI configuration to build es-private-fields branch

0af8860

Parse Private Names

221111e

and check that private names not used in parameters Signed-off-by: Max Heiber <max.heiber@gmail.com> Signed-off-by: Max Heiber <mheiber@bloomberg.net>

mheiber force-pushed the es-private-fields branch from 853486f to 221111e Compare October 29, 2018 21:36

Joseph Watts and others added 3 commits November 12, 2018 15:46

Move class property transformation into ESNext transformer

75af3b7

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Baseline changes for ESNext Class Property Transformation (#4)

861936e

* Add baselines * Update baselines Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Neuroboy23 force-pushed the master branch from d07317a to cb6325d Compare November 27, 2018 21:20

Joseph Watts and others added 8 commits December 10, 2018 11:05

Fix display of private names in language server

1687b4b

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Accept baseline changes

3fc3756

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Merge pull request #11 from joeywatts/private-name-server-display

979155c

Fix display of private names in the TS Language Server

Downlevel private named field initializers

b7ea7f4

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Transform property access for private named instance fields

229f3ae

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Transform private name bindings in destructuring assignments

7bf2171

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Transform call expressions on private names to properly bind this

fa17cdf

Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>

Merge pull request #15 from joeywatts/esnext-private-instance-fields

8bfc540

Transform private named instance fields

mheiber closed this Dec 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All Bloomberg Changes for Private Fields and Methods #6

All Bloomberg Changes for Private Fields and Methods #6

mheiber commented Aug 23, 2018 •

edited

Loading

All Bloomberg Changes for Private Fields and Methods #6

All Bloomberg Changes for Private Fields and Methods #6

Conversation

mheiber commented Aug 23, 2018 • edited Loading

mheiber commented Aug 23, 2018 •

edited

Loading