Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in SourceUtil::getMacroNameForStatement #53

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

dbeer1
Copy link
Contributor

@dbeer1 dbeer1 commented Jun 12, 2020

Describe your changes
Macro names were not being resolved for statements that were passed as macro arguments as the code was excluding too many input statements.

Testing performed
Added new test 034-macro-name-for-statement

@dbeer1 dbeer1 requested review from azeemba and ruoso June 12, 2020 18:41
@dbeer1
Copy link
Contributor Author

dbeer1 commented Jun 12, 2020

CC: @begroh, @envp

@dbeer1
Copy link
Contributor Author

dbeer1 commented Jun 15, 2020

#54 put in to fix docker build

Signed-off-by: Daniel Beer <dbeer1@bloomberg.net>
Copy link
Contributor

@envp envp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@dbeer1 dbeer1 merged commit e3a9d09 into bloomberg:master Jun 16, 2020
@dbeer1 dbeer1 deleted the macro_name_bug branch June 16, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants