Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable compass menu #51

Closed
wants to merge 5 commits into from
Closed

Customizable compass menu #51

wants to merge 5 commits into from

Conversation

MoonPadUSer
Copy link
Contributor

@MoonPadUSer MoonPadUSer commented Jun 8, 2020 •
edited by TheAssassin
Loading

Adds new tab to the User Interface Options:
NewTab
You can modify up to 6 shortcuts by setting a name and entering any cubescript command in the action field like this:
ShowcaseCommand
In-Game you can then press the C key (rebindable) and it'll pop up a compass menu:
OpenMenu
they work exactly like the voiceline compass menus, so when you press a shortcut (in this case: "Hello World!") and it'll execute the command you entered before
Demonstration

Closes #45.

@MoonPadUSer MoonPadUSer mentioned this pull request Jun 8, 2020
Open
@TheAssassin
Copy link
Member

Not sure if I like this very much. I'd make it strictly opt-in. Most people, including me, probably won't want to use this.

Also, I'm not so sure about the default bind c. I know tons of players using c to crouch, they're used to this from many other games. We need to find an alternative.

@MoonPadUSer
Copy link
Contributor Author

Not sure if I like this very much. I'd make it strictly opt-in. Most people, including me, probably won't want to use this.

Also, I'm not so sure about the default bind c. I know tons of players using c to crouch, they're used to this from many other games. We need to find an alternative.

  1. I am not sure if I get what you mean. It is as opt-in as the normal voiceline compass menus, you don't have to use it if you don't want to, it's just about giving people the opportunity to bind anything to a button in this compass menu
  2. I agree with you that C is not the best keybind. I'll do some testing and see what other keybinds are available.

@TheAssassin TheAssassin changed the title Custom compass menu entries Customizable compass menu Jun 19, 2020
@TheAssassin TheAssassin added the enhancement New feature or request label Jun 19, 2020
ghost
ghost suggested changes Jun 24, 2020
View reviewed changes
src/engine/menus.cpp
@@ -11,6 +11,19 @@ struct menu;
static guient *cgui = NULL;
static menu *cmenu = NULL;

SVAR(IDF_PERSIST, customcompassentryname1, "");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new vars. No doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can remove those too.... xD

src/engine/menus.cpp
@@ -737,6 +755,7 @@ COMMAND(0, ui_tooltip, "si");
COMMAND(0, ui_textfield, "sisbisisi");
COMMAND(0, ui_keyfield, "sisbissi");
COMMAND(0, ui_editor, "siiibisss");
COMMAND(0, ui_execute , "s");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new command, no doc. Why not using execute() directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can actually remove this entire thing

@MoonPadUSer MoonPadUSer marked this pull request as draft June 27, 2020 16:22
@MoonPadUSer MoonPadUSer self-assigned this Jun 27, 2020
@MoonPadUSer
Copy link
Contributor Author

I am going to close this PR because it's outdated and I'd rather rewrite it entirely since there are many things that can be improved a lot

@MoonPadUSer MoonPadUSer closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@MoonPadUSer MoonPadUSer

Labels
enhancement New feature or request user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom entries for compass menu
2 participants
@MoonPadUSer @TheAssassin