Let user scroll to next page when PageView child is zooming (#41) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#e2fc11)DeepCode analyzed this pull request. |
|
It would be very appreciate if you can take a time to check this pr |
|
Wilco. First thing tonight. Sorry for the delay. |
renancaraujo
requested changes
Oct 15, 2019
There was a problem hiding this comment.
I really liked your approach of conversating gesture detectors (or at least overriding).
Thanks for your contribution. I got to reserve a nice amount of time to review this properly.
I was thinking about tackling it with a "physics" strategy, which is being proved very, very complex. This is way simpler.
Once those changes are made, I will be happy to test if we got any bugs and performance still good and then merge. This is by far the most important contribution I ever received here. Thank you.
criswonder
commented
Oct 16, 2019
renancaraujo
force-pushed
the
pageview
branch
from
1addf05
to
e2fc118
Compare
renancaraujo
approved these changes
Oct 16, 2019
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rebase with master, I open this new pull request, please take a look, thank you!