Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: add no-else-return #2564

Merged
merged 1 commit into from
Apr 24, 2024
Merged

eslint: add no-else-return #2564

merged 1 commit into from
Apr 24, 2024

Conversation

Williangalvani
Copy link
Member

This catches unnecessary else blocks. sadly doesn't seems to work after throw

also, this works with --fix, which is neat

patrickelectric
patrickelectric reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait.. don't we have any occurrance of that in the code ?

@Williangalvani
Copy link
Member Author

Wait.. don't we have any occurrance of that in the code ?

apparently not. good job. I had to manually do it in order to to test

@patrickelectric patrickelectric merged commit aeeb1e7 into bluerobotics:master Apr 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Williangalvani @patrickelectric