Add: examples: cpp: CMake Standalone auto fetch latest available tag [todo] #68
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested changes
Mar 14, 2024
|
|
||
| # Function to fetch latest release version from GitHub | ||
| function(fetch_latest_release owner_name repo_name out_variable) | ||
| file(DOWNLOAD "https://api.github.com/repos/${owner_name}/${repo_name}/releases/latest" "${CMAKE_BINARY_DIR}/latest_release.json" TLS_VERIFY ON) |
There was a problem hiding this comment.
Use CMAKE_BUILD_DIR over CMAKE_BINARY_DIR, otherwise the artifact folder will also contain the json file as well. it's a temporary file, it should exist in a temporary folder.
There was a problem hiding this comment.
can't use CMAKE_BUILD_DIR,
tried CMAKE_CACHEFILE_DIR, but to make it works you need to run twice (something related to permissions)
was unable to find CMAKE_BUILD_DIR
https://cmake.org/cmake/help/latest/search.html?q=CMAKE_BUILD_
RaulTrombin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
