-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Benchmarking with Criterion #53
Add: Benchmarking with Criterion #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests does not check if the function calls are failing, we may fail fast without knowing. So the benchmark does not make much sense.
We need to check if there are no errors.
Our functions are returning the types directly, not a result, but internally they are unwrapping() inner results, and seems to stop if reach any error. example:
Running bench:
|
The library functions should return result and not unwrap inside it. |
We can merge at it is, but we should fix that. |
A fast way to benchmark our functions, seems work pretty fine locally and on hosted-ci-runner.
cargo bench --jobs 1 --bench bench | tee output.txt