Improve I2C receive retry logic #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The loss of coverage is from an uncovered branch for exiting a loop, not an uncovered line. As this is the case, I intend to override the coverage check. |
haydenroche5
approved these changes
Sep 29, 2023
src/NoteI2c_Arduino.cpp
Outdated
| result = ERRSTR("serial-over-i2c: unexpected raw byte count {io}",i2cerr); | ||
| } else { | ||
| // Ensure available byte count is within expected range | ||
| static const size_t AVAILBLE_MAX = (NoteI2c::REQUEST_MAX_SIZE - NoteI2c::REQUEST_HEADER_SIZE); |
There was a problem hiding this comment.
AVAILBLE -> AVAILABLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification was made to improve the experience with the Notecard ESP, and has been tested quite extensively.