-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Update note-c
to v2.5.2
#148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces heartbeat callback support and improves documentation consistency across the note-c library. The heartbeat functionality enables applications to receive periodic status updates from the Notecard during long-running operations.
- Added optional heartbeat callback functionality with compile-time feature flag
- Reorganized typedef declarations in note.h for better alphabetical ordering
- Added comprehensive documentation with detailed function descriptions and parameter documentation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/note-c/note.h | Reorganized typedef declarations, added extensive function documentation, and heartbeat callback definitions |
src/note-c/n_serial.c | Added limits.h include and improved error handling with conditional request transmission |
src/note-c/n_request.c | Added transaction timeout override functionality and heartbeat processing logic |
src/note-c/n_lib.h | Added heartbeat callback declarations and reorganized constant definitions |
src/note-c/n_i2c.c | Improved documentation and added conditional request transmission logic |
src/note-c/n_hooks.c | Added heartbeat callback hooks and renamed function from NoteSetFnI2cDefault to NoteSetFnI2CDefault |
src/note-c/n_const.c | Reorganized constant definitions alphabetically |
src/note-c/n_cjson_helpers.c | Removed duplicate documentation that's now in header file |
src/note-c/CMakeLists.txt | Added NOTE_C_HEARTBEAT_CALLBACK build option |
src/note-c/.gitignore | Added .claude/ directory to gitignore |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
git-subtree-dir: src/note-c git-subtree-split: 56d35efdf40b1abd1936c0297baf9eb31535bdd8
d77b095
to
7b9771e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
note-c
to v2.5.1note-c
to v2.5.2
No description provided.