Skip to content

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Sep 22, 2025

No description provided.

@zfields zfields requested a review from Copilot September 22, 2025 15:54
@zfields zfields changed the title Zak upd note c chore: Update note-c to v2.5.1 Sep 22, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces heartbeat callback support and improves documentation consistency across the note-c library. The heartbeat functionality enables applications to receive periodic status updates from the Notecard during long-running operations.

  • Added optional heartbeat callback functionality with compile-time feature flag
  • Reorganized typedef declarations in note.h for better alphabetical ordering
  • Added comprehensive documentation with detailed function descriptions and parameter documentation

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/note-c/note.h Reorganized typedef declarations, added extensive function documentation, and heartbeat callback definitions
src/note-c/n_serial.c Added limits.h include and improved error handling with conditional request transmission
src/note-c/n_request.c Added transaction timeout override functionality and heartbeat processing logic
src/note-c/n_lib.h Added heartbeat callback declarations and reorganized constant definitions
src/note-c/n_i2c.c Improved documentation and added conditional request transmission logic
src/note-c/n_hooks.c Added heartbeat callback hooks and renamed function from NoteSetFnI2cDefault to NoteSetFnI2CDefault
src/note-c/n_const.c Reorganized constant definitions alphabetically
src/note-c/n_cjson_helpers.c Removed duplicate documentation that's now in header file
src/note-c/CMakeLists.txt Added NOTE_C_HEARTBEAT_CALLBACK build option
src/note-c/.gitignore Added .claude/ directory to gitignore

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zfields zfields changed the title chore: Update note-c to v2.5.1 chore: Update note-c to v2.5.2 Sep 23, 2025
@zfields zfields requested a review from Bucknalla September 23, 2025 00:42
@zfields zfields merged commit 3a8a7b5 into master Sep 23, 2025
94 checks passed
@zfields zfields deleted the zak-upd-note-c branch September 23, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant