Skip to content

feat: Unit-test static interface methods #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2021
Merged

feat: Unit-test static interface methods #60

merged 3 commits into from
Aug 13, 2021

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Aug 12, 2021

No description provided.

@zfields zfields requested a review from m-mcgowan August 12, 2021 04:12
@zfields zfields marked this pull request as ready for review August 12, 2021 04:12
m-mcgowan
m-mcgowan approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@m-mcgowan m-mcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code equivalent of polishing a floor with a toothbrush! There's plenty I could say about this but I understand it's a temporary standin before we move to a test framework that expresses these assertions more concisely. 👏 for braving the gruntwork.

@zfields zfields merged commit 1413dcd into master Aug 13, 2021
@zfields zfields deleted the zak-static-cov branch August 13, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@m-mcgowan m-mcgowan m-mcgowan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zfields @m-mcgowan