Don't create unnecessary error objects (#1908)

* Don't create unnecessary error objects * add changeset --------- Co-authored-by: dholms <dtholmgren@gmail.com>
bluesky-social · Nov 30, 2023 · 3c0ef38 · 3c0ef38
1 parent 6da8182
commit 3c0ef38
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/brave-swans-kiss.md b/.changeset/brave-swans-kiss.md
@@ -0,0 +1,5 @@
+---
+'@atproto/syntax': patch
+---
+
+prevent unnecessary throw/catch on uri syntax
diff --git a/packages/syntax/src/aturi_validation.ts b/packages/syntax/src/aturi_validation.ts
@@ -38,13 +38,13 @@ export const ensureValidAtUri = (uri: string) => {
   }
 
   try {
-    ensureValidHandle(parts[2])
-  } catch {
-    try {
+    if (parts[2].startsWith('did:')) {
       ensureValidDid(parts[2])
-    } catch {
-      throw new Error('ATURI authority must be a valid handle or DID')
+    } else {
+      ensureValidHandle(parts[2])
     }
+  } catch {
+    throw new Error('ATURI authority must be a valid handle or DID')
   }
 
   if (parts.length >= 4) {