Action !takedown labels in hydrator (#2270)

* action takedown labels in hydrator * wip tests * fix tests & better hydration * tidy up includeTakedowns * update labelers header semantics * add response header * pds: pipe through res headers * fix up tests * tidy tests * re-include example in dev-env * fix test * revamp parsing * fix build err in hydrator * fix more build errs * fix test
bluesky-social · Mar 12, 2024 · 3d32d1c · 3d32d1c
1 parent 7b14660
commit 3d32d1c
Show file tree

Hide file tree

Showing 14 changed files with 285 additions and 104 deletions.
diff --git a/packages/bsky/src/api/app/bsky/actor/getProfile.ts b/packages/bsky/src/api/app/bsky/actor/getProfile.ts
@@ -16,14 +16,11 @@ export default function (server: Server, ctx: AppContext) {
   server.app.bsky.actor.getProfile({
     auth: ctx.authVerifier.optionalStandardOrRole,
     handler: async ({ auth, params, req }) => {
-      const { viewer, canViewTakedowns } = ctx.authVerifier.parseCreds(auth)
+      const { viewer, includeTakedowns } = ctx.authVerifier.parseCreds(auth)
       const labelers = ctx.reqLabelers(req)
-      const hydrateCtx = { labelers, viewer }
+      const hydrateCtx = { labelers, viewer, includeTakedowns }
 
-      const result = await getProfile(
-        { ...params, hydrateCtx, canViewTakedowns },
-        ctx,
-      )
+      const result = await getProfile({ ...params, hydrateCtx }, ctx)
 
       const repoRev = await ctx.hydrator.actor.getRepoRevSafe(viewer)
 
@@ -57,11 +54,10 @@ const hydration = async (input: {
   skeleton: SkeletonState
 }) => {
   const { ctx, params, skeleton } = input
-  return ctx.hydrator.hydrateProfilesDetailed(
-    [skeleton.did],
-    params.hydrateCtx,
-    true,
-  )
+  return ctx.hydrator.hydrateProfilesDetailed([skeleton.did], {
+    ...params.hydrateCtx,
+    includeTakedowns: true,
+  })
 }
 
 const presentation = (input: {
@@ -75,7 +71,7 @@ const presentation = (input: {
   if (!profile) {
     throw new InvalidRequestError('Profile not found')
   } else if (
-    !params.canViewTakedowns &&
+    !params.hydrateCtx.includeTakedowns &&
     ctx.views.actorIsTakendown(skeleton.did, hydration)
   ) {
     throw new InvalidRequestError(
@@ -93,7 +89,6 @@ type Context = {
 
 type Params = QueryParams & {
   hydrateCtx: HydrateCtx
-  canViewTakedowns: boolean
 }
 
 type SkeletonState = { did: string }
diff --git a/packages/bsky/src/api/app/bsky/actor/getSuggestions.ts b/packages/bsky/src/api/app/bsky/actor/getSuggestions.ts
@@ -66,11 +66,7 @@ const hydration = async (input: {
   skeleton: Skeleton
 }) => {
   const { ctx, params, skeleton } = input
-  return ctx.hydrator.hydrateProfilesDetailed(
-    skeleton.dids,
-    params.hydrateCtx,
-    true,
-  )
+  return ctx.hydrator.hydrateProfilesDetailed(skeleton.dids, params.hydrateCtx)
 }
 
 const noBlocksOrMutes = (input: {

diff --git a/packages/bsky/src/api/app/bsky/feed/getAuthorFeed.ts b/packages/bsky/src/api/app/bsky/feed/getAuthorFeed.ts
@@ -28,14 +28,11 @@ export default function (server: Server, ctx: AppContext) {
   server.app.bsky.feed.getAuthorFeed({
     auth: ctx.authVerifier.optionalStandardOrRole,
     handler: async ({ params, auth, req }) => {
-      const { viewer, canViewTakedowns } = ctx.authVerifier.parseCreds(auth)
+      const { viewer, includeTakedowns } = ctx.authVerifier.parseCreds(auth)
       const labelers = ctx.reqLabelers(req)
-      const hydrateCtx = { labelers, viewer }
+      const hydrateCtx = { labelers, viewer, includeTakedowns }
 
-      const result = await getAuthorFeed(
-        { ...params, hydrateCtx, includeTakedowns: canViewTakedowns },
-        ctx,
-      )
+      const result = await getAuthorFeed({ ...params, hydrateCtx }, ctx)
 
       const repoRev = await ctx.hydrator.actor.getRepoRevSafe(viewer)
 
@@ -69,7 +66,7 @@ export const skeleton = async (inputs: {
   }
   const actors = await ctx.hydrator.actor.getActors(
     [did],
-    params.includeTakedowns,
+    params.hydrateCtx.includeTakedowns,
   )
   const actor = actors.get(did)
   if (!actor) {
@@ -103,11 +100,7 @@ const hydration = async (inputs: {
 }): Promise<HydrationState> => {
   const { ctx, params, skeleton } = inputs
   const [feedPostState, profileViewerState] = await Promise.all([
-    ctx.hydrator.hydrateFeedItems(
-      skeleton.items,
-      params.hydrateCtx,
-      params.includeTakedowns,
-    ),
+    ctx.hydrator.hydrateFeedItems(skeleton.items, params.hydrateCtx),
     ctx.hydrator.hydrateProfileViewers([skeleton.actor.did], params.hydrateCtx),
   ])
   return mergeStates(feedPostState, profileViewerState)
@@ -163,7 +156,6 @@ type Context = {
 
 type Params = QueryParams & {
   hydrateCtx: HydrateCtx
-  includeTakedowns: boolean
 }
 
 type Skeleton = {

diff --git a/packages/bsky/src/api/app/bsky/graph/getFollowers.ts b/packages/bsky/src/api/app/bsky/graph/getFollowers.ts
@@ -29,14 +29,11 @@ export default function (server: Server, ctx: AppContext) {
   server.app.bsky.graph.getFollowers({
     auth: ctx.authVerifier.optionalStandardOrRole,
     handler: async ({ params, auth, req }) => {
-      const { viewer, canViewTakedowns } = ctx.authVerifier.parseCreds(auth)
+      const { viewer, includeTakedowns } = ctx.authVerifier.parseCreds(auth)
       const labelers = ctx.reqLabelers(req)
-      const hydrateCtx = { labelers, viewer }
+      const hydrateCtx = { labelers, viewer, includeTakedowns }
 
-      const result = await getFollowers(
-        { ...params, hydrateCtx, canViewTakedowns },
-        ctx,
-      )
+      const result = await getFollowers({ ...params, hydrateCtx }, ctx)
 
       return {
         encoding: 'application/json',
@@ -85,7 +82,6 @@ const hydration = async (
   const profileState = await ctx.hydrator.hydrateProfiles(
     dids,
     params.hydrateCtx,
-    params.canViewTakedowns,
   )
   return mergeStates(followState, profileState)
 }
@@ -112,13 +108,16 @@ const presentation = (
     ctx.views.actorIsTakendown(did, hydration)
 
   const subject = ctx.views.profile(subjectDid, hydration)
-  if (!subject || (!params.canViewTakedowns && isTakendown(subjectDid))) {
+  if (
+    !subject ||
+    (!params.hydrateCtx.includeTakedowns && isTakendown(subjectDid))
+  ) {
     throw new InvalidRequestError(`Actor not found: ${params.actor}`)
   }
 
   const followers = mapDefined(followUris, (followUri) => {
     const followerDid = didFromUri(followUri)
-    if (!params.canViewTakedowns && isTakendown(followerDid)) {
+    if (!params.hydrateCtx.includeTakedowns && isTakendown(followerDid)) {
       return
     }
     return ctx.views.profile(didFromUri(followUri), hydration)
@@ -134,7 +133,6 @@ type Context = {
 
 type Params = QueryParams & {
   hydrateCtx: HydrateCtx
-  canViewTakedowns: boolean
 }
 
 type SkeletonState = {

diff --git a/packages/bsky/src/api/app/bsky/graph/getFollows.ts b/packages/bsky/src/api/app/bsky/graph/getFollows.ts
@@ -23,15 +23,12 @@ export default function (server: Server, ctx: AppContext) {
   server.app.bsky.graph.getFollows({
     auth: ctx.authVerifier.optionalStandardOrRole,
     handler: async ({ params, auth, req }) => {
-      const { viewer, canViewTakedowns } = ctx.authVerifier.parseCreds(auth)
+      const { viewer, includeTakedowns } = ctx.authVerifier.parseCreds(auth)
       const labelers = ctx.reqLabelers(req)
-      const hydrateCtx = { labelers, viewer }
+      const hydrateCtx = { labelers, viewer, includeTakedowns }
 
       // @TODO ensure canViewTakedowns gets threaded through and applied properly
-      const result = await getFollows(
-        { ...params, hydrateCtx, canViewTakedowns },
-        ctx,
-      )
+      const result = await getFollows({ ...params, hydrateCtx }, ctx)
 
       return {
         encoding: 'application/json',
@@ -80,7 +77,6 @@ const hydration = async (
   const profileState = await ctx.hydrator.hydrateProfiles(
     dids,
     params.hydrateCtx,
-    params.canViewTakedowns,
   )
   return mergeStates(followState, profileState)
 }
@@ -109,14 +105,17 @@ const presentation = (
     ctx.views.actorIsTakendown(did, hydration)
 
   const subject = ctx.views.profile(subjectDid, hydration)
-  if (!subject || (!params.canViewTakedowns && isTakendown(subjectDid))) {
+  if (
+    !subject ||
+    (!params.hydrateCtx.includeTakedowns && isTakendown(subjectDid))
+  ) {
     throw new InvalidRequestError(`Actor not found: ${params.actor}`)
   }
 
   const follows = mapDefined(followUris, (followUri) => {
     const followDid = hydration.follows?.get(followUri)?.record.subject
     if (!followDid) return
-    if (!params.canViewTakedowns && isTakendown(followDid)) {
+    if (!params.hydrateCtx.includeTakedowns && isTakendown(followDid)) {
       return
     }
     return ctx.views.profile(followDid, hydration)
@@ -132,7 +131,6 @@ type Context = {
 
 type Params = QueryParams & {
   hydrateCtx: HydrateCtx
-  canViewTakedowns: boolean
 }
 
 type SkeletonState = {

diff --git a/packages/bsky/src/api/com/atproto/admin/getAccountInfos.ts b/packages/bsky/src/api/com/atproto/admin/getAccountInfos.ts
@@ -8,16 +8,16 @@ export default function (server: Server, ctx: AppContext) {
     auth: ctx.authVerifier.optionalStandardOrRole,
     handler: async ({ params, auth }) => {
       const { dids } = params
-      const { canViewTakedowns } = ctx.authVerifier.parseCreds(auth)
+      const { includeTakedowns } = ctx.authVerifier.parseCreds(auth)
 
       const actors = await ctx.hydrator.actor.getActors(dids, true)
 
       const infos = mapDefined(dids, (did) => {
         const info = actors.get(did)
         if (!info) return
-        if (info.takedownRef && !canViewTakedowns) return
+        if (info.takedownRef && !includeTakedowns) return
         const profileRecord =
-          !info.profileTakedownRef || canViewTakedowns
+          !info.profileTakedownRef || includeTakedowns
             ? info.profile
             : undefined
         return {

diff --git a/packages/bsky/src/auth-verifier.ts b/packages/bsky/src/auth-verifier.ts
@@ -258,7 +258,7 @@ export class AuthVerifier {
   ) {
     const viewer =
       creds.credentials.type === 'standard' ? creds.credentials.iss : null
-    const canViewTakedowns =
+    const includeTakedowns =
       (creds.credentials.type === 'role' && creds.credentials.admin) ||
       creds.credentials.type === 'mod_service' ||
       (creds.credentials.type === 'standard' &&
@@ -269,7 +269,7 @@ export class AuthVerifier {
 
     return {
       viewer,
-      canViewTakedowns,
+      includeTakedowns,
       canPerformTakedown,
     }
   }