Configurable catchall on xrpc-server (#2384)

* allow configurable catchall on xrpc-server * changeset
bluesky-social · Apr 4, 2024 · cd4fcc7 · cd4fcc7
1 parent 115df69
commit cd4fcc7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/.changeset/lovely-parrots-talk.md b/.changeset/lovely-parrots-talk.md
@@ -0,0 +1,5 @@
+---
+'@atproto/xrpc-server': patch
+---
+
+Add configurable catchall
diff --git a/packages/xrpc-server/src/server.ts b/packages/xrpc-server/src/server.ts
@@ -72,7 +72,10 @@ export class Server {
       this.addLexicons(lexicons)
     }
     this.router.use(this.routes)
-    this.router.use('/xrpc/:methodId', this.catchall.bind(this))
+    this.router.use(
+      '/xrpc/:methodId',
+      opts?.catchall ?? this.catchall.bind(this),
+    )
     this.router.use(errorMiddleware)
     this.router.once('mount', (app: Application) => {
       this.enableStreamingOnListen(app)

diff --git a/packages/xrpc-server/src/types.ts b/packages/xrpc-server/src/types.ts
@@ -8,8 +8,15 @@ import {
   ResponseTypeNames,
 } from '@atproto/xrpc'
 
+export type CatchallHandler = (
+  req: express.Request,
+  _res: express.Response,
+  next: express.NextFunction,
+) => unknown
+
 export type Options = {
   validateResponse?: boolean
+  catchall?: CatchallHandler
   payload?: {
     jsonLimit?: number
     blobLimit?: number