Clean up what's hot #1002
Clean up what's hot #1002
Conversation
| const noRecordEmbeds = feed.map((post) => { | ||
| delete post.post.record['embed'] | ||
| if (post.reply) { | ||
| delete post.reply.parent.record['embed'] | ||
| delete post.reply.root.record['embed'] | ||
| } | ||
| return post | ||
| }) |
There was a problem hiding this comment.
Records that contain image or external embeds will still show-up here— is this logic just not needed at all anymore? I recall it goes back to some issues with lexicon validation and the client.
There was a problem hiding this comment.
oh shit that's right... okay this does need to be back in my bad
packages/pds/tests/seeds/basic.ts
Outdated
| @@ -38,6 +38,7 @@ export default async (sc: SeedClient) => { | |||
| [img1, img2], // Contains both images and a quote | |||
| sc.posts[bob][0].ref, | |||
| ) | |||
| await sc.post(carol, posts.carol[0]) | |||
There was a problem hiding this comment.
I see posts.carol[0] used above—is this intended to be the newly-added post posts.carol[1]?
|
If it was up to me:
I haven't checked, but to date we have only had I know that "ignore unknown labels" is working it's way through the app pipeline, but I don't know how broadly it is deployed. If it was, we could rip out the "don't hydrate" logic. I think expanding |
* changes to clean up whats hot * fix test * add quote posts back in & use underwear label instead of no-promote * tidy
* changes to clean up whats hot * fix test * add quote posts back in & use underwear label instead of no-promote * tidy
* changes to clean up whats hot * fix test * add quote posts back in & use underwear label instead of no-promote * tidy
Generally trying to reduce nsfw & raunchy material in what's hot, we apply 3 fixes:
I also updated our labeling service to accurately return
!no-promotelabels