Return custom suggestions #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
May 29, 2023
| export async function up(db: Kysely<unknown>): Promise<void> { | ||
| await db.schema | ||
| .createTable('suggested_follow') | ||
| .addColumn('did', 'varchar', (col) => col.primaryKey()) |
There was a problem hiding this comment.
Any use for a column here to control the order?
There was a problem hiding this comment.
actually yeah that's probably smart 👍 otherwise we just get them in did-alphabetic order
devinivy
approved these changes
May 29, 2023
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* return custom suggestions on server * allow ordered suggestions
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* return custom suggestions on server * allow ordered suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a PDS to return a curated list of suggested follows
These suggested follows are stored in a simple database table.