Appview blocks #1187
Merged
Appview blocks #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jun 9, 2023
Comment on lines
+78
to
+83
| async processAll(timeout?: number) { | ||
| await this.pds.ctx.backgroundQueue.processAll() | ||
| if (!this.bsky) return | ||
| await this.processFullSubscription(timeout) | ||
| await this.bsky.ctx.backgroundQueue.processAll() | ||
| } |
There was a problem hiding this comment.
Yupyup, been wanting to do exactly this 💪
devinivy
reviewed
Jun 10, 2023
Comment on lines
466
to
476
| function truncateUtf8(str: string | null | undefined, length: number) { | ||
| if (!str) return str | ||
| const encoder = new TextEncoder() | ||
| const utf8 = encoder.encode(str) | ||
| if (utf8.length > length) { | ||
| const decoder = new TextDecoder('utf-8', { fatal: false }) | ||
| const truncated = utf8.slice(0, length) | ||
| return decoder.decode(truncated).replace(/\uFFFD$/, '') | ||
| } | ||
| return str | ||
| } |
There was a problem hiding this comment.
I think we can get rid of this now that all clients are compatible with the lex refactor.
There was a problem hiding this comment.
ah cool cool checks out 👍
i couldn't quite remember when we'd added this in & erred on the side of caution
devinivy
reviewed
Jun 10, 2023
| @@ -54,6 +56,7 @@ export class IndexingService { | |||
| profile: Profile.makePlugin(this.db, backgroundQueue), | |||
| list: List.makePlugin(this.db, backgroundQueue), | |||
| listItem: ListItem.makePlugin(this.db, backgroundQueue), | |||
| block: Block.makePlugin(this.db, backgroundQueue), | |||
There was a problem hiding this comment.
I think we should remove records from the actor_block table during unindexActor() too.
There was a problem hiding this comment.
oh yup totally. good call 👍
devinivy
reviewed
Jun 10, 2023
| ).toBeFalsy() | ||
| }) | ||
|
|
||
| // it('strips blocked users out of getPopular', async () => { |
There was a problem hiding this comment.
Does this remain commented out intentionally?
There was a problem hiding this comment.
yea removed that method from the appview - i'll just remove this test
devinivy
approved these changes
Jun 10, 2023
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* Model post and profile aggs in bsky * Add background, onCommit, db and background stats * Add aggregations for post and profile * Use background queue in bsky labeler, misc plumbing * Process background throughout bsky tests * bsky tidy and fixes * Build views using agg tables in bsky * Views of feedgens on bsky * hook up indexing * Setup custom feeds on bsky * graph service + getList routes * migration * Feed views refactor for bsky, implement getFeed w/ auth passthrough * mute lists * add getListMutes * mute list tests * add mutes table & mute/unmuteActor routes * Passthrough auth from bsky appview to feedgen, fixes/tidy/tests * add getMutes * implement mute functionality * remove unspecced * mute tests * mute impl tests * remove proxy tests * Test custom algos on bsky * add mute state to snapshots * table & indexing plugin * getBlocks * bail out of mute subquery when no viewer * fleshing out services * Test pds getFeed proxy * tidy, fix build * tidy * Fix minor race in bsky mutelist tests * blocks in feed views * db migration, impl block logic & tests * Update pds proxy snaps based on appview mutes * missed some files on last commit * ensure process after unmute * update snap * move adminAuth to seedclient param * apply blocks in getFeed * update snaps * upadate one last snap * pr feedback --------- Co-authored-by: Devin Ivy <devinivy@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* Model post and profile aggs in bsky * Add background, onCommit, db and background stats * Add aggregations for post and profile * Use background queue in bsky labeler, misc plumbing * Process background throughout bsky tests * bsky tidy and fixes * Build views using agg tables in bsky * Views of feedgens on bsky * hook up indexing * Setup custom feeds on bsky * graph service + getList routes * migration * Feed views refactor for bsky, implement getFeed w/ auth passthrough * mute lists * add getListMutes * mute list tests * add mutes table & mute/unmuteActor routes * Passthrough auth from bsky appview to feedgen, fixes/tidy/tests * add getMutes * implement mute functionality * remove unspecced * mute tests * mute impl tests * remove proxy tests * Test custom algos on bsky * add mute state to snapshots * table & indexing plugin * getBlocks * bail out of mute subquery when no viewer * fleshing out services * Test pds getFeed proxy * tidy, fix build * tidy * Fix minor race in bsky mutelist tests * blocks in feed views * db migration, impl block logic & tests * Update pds proxy snaps based on appview mutes * missed some files on last commit * ensure process after unmute * update snap * move adminAuth to seedclient param * apply blocks in getFeed * update snaps * upadate one last snap * pr feedback --------- Co-authored-by: Devin Ivy <devinivy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements blocks on the appview