Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: fallback to getRecord on appview, misc fixes #1210

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

devinivy
Copy link
Collaborator

Porting some changes from a109e14

  • Implement getRecord on appview to support some usage by the client via @atproto/api.
  • Fallback to appview in getRecord on the pds when applicable.
  • Temporarily use requestCrawl rather than notifyOfUpdate for notifying crawlers.
  • Misc tidying.

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent thanks for that!

@devinivy devinivy merged commit ffc6451 into main Jun 15, 2023
@devinivy devinivy deleted the port-appview-fixes branch June 15, 2023 20:41
dholms added a commit that referenced this pull request Jun 22, 2023
* bugfixing sandbox issues

* tidy after backport

---------

Co-authored-by: dholms <dtholmgren@gmail.com>
mloar pushed a commit to mloar/atproto that referenced this pull request Sep 26, 2023
…l#1210)

* bugfixing sandbox issues

* tidy after backport

---------

Co-authored-by: dholms <dtholmgren@gmail.com>
mloar pushed a commit to mloar/atproto that referenced this pull request Nov 15, 2023
…l#1210)

* bugfixing sandbox issues

* tidy after backport

---------

Co-authored-by: dholms <dtholmgren@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants